Summary
Pre-existing SonarCloud findings in _spaceCatcher (l2t-paper-slider.js) that were present on master before PR #51 are now surfacing in the SonarCloud diff analysis for that PR because the function was modified.
Findings
var declaration (SonarCloud failure): var nextPos should be const nextPos (or let if reassigned).
parseInt without explicit radix (SonarCloud warning): parseInt(nextPos) should be Number.parseInt(nextPos, 10).
Impact
The var finding is a SonarCloud failure (not merely a warning) and may block the quality gate on any future PR that touches this function.
Suggested fix
const nextPos = activeEl.getAttribute('aria-posinset');
if (nextPos) this.movePos(Number.parseInt(nextPos, 10) - 1);
References
Summary
Pre-existing SonarCloud findings in
_spaceCatcher(l2t-paper-slider.js) that were present onmasterbefore PR #51 are now surfacing in the SonarCloud diff analysis for that PR because the function was modified.Findings
vardeclaration (SonarCloud failure):var nextPosshould beconst nextPos(orletif reassigned).parseIntwithout explicit radix (SonarCloud warning):parseInt(nextPos)should beNumber.parseInt(nextPos, 10).Impact
The
varfinding is a SonarCloud failure (not merely a warning) and may block the quality gate on any future PR that touches this function.Suggested fix
References