Hook control mode was changed to direct in task#815
Merged
Conversation
knopers8
approved these changes
May 8, 2026
Collaborator
knopers8
left a comment
knopers8
left a comment
There was a problem hiding this comment.
I had a look around and it seems that this function is not called anywhere, maybe it was something added for walnut, judging by the author.
Seems safe to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During my kubernetes work, I found this weird forking of control mode in task.go which silently move hook to direct control task. This seems weird especially when we have dedicated HookTask (see). I cannot say whether this was done deliberately or whether it is a bug, but it feels like a bug.