fix(sitemap): include statically-generated toolkit pages#971
Draft
teallarson wants to merge 2 commits into
Draft
fix(sitemap): include statically-generated toolkit pages#971teallarson wants to merge 2 commits into
teallarson wants to merge 2 commits into
Conversation
Toolkit pages at /en/resources/integrations/{category}/{toolkitId} were
excluded from the sitemap because the filesystem walk skips directories
whose names contain "[". This means search engines had no direct signal
to crawl them.
Uses the existing listToolkitRoutes() helper to append toolkit URLs after
the MDX walk, deduplicates across both sources, and excludes the "others"
category which has no on-disk route.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Toolkit pages at
/en/resources/integrations/{category}/{toolkitId}were missing fromsitemap.xmlbecause the filesystem walk inapp/sitemap.tsskips directories whose names contain[, dropping all[toolkitId]dynamic route folders. This means search engines get no direct signal to crawl ~100 toolkit pages.buildSitemap()helper that runs the MDX walk andlistToolkitRoutes()in parallel, then merges, deduplicates, and sorts the resultsotherscategory (no on-disk route, redirected bynext.config.ts)tests/sitemap.test.tsto assert a known toolkit URL is present, >10 integration URLs exist, and no[placeholder leaksRelated
attributeForDistinctconfig change is being applied separately in the crawler dashboard)lastModifiedlookup to keep it lean)Test plan
https://docs.arcade.dev/sitemap.xmlcontains/en/resources/integrations/development/githuband other toolkit URLs