add thiserror, split error::Error into different modules#324
Open
gerau wants to merge 8 commits into
Open
Conversation
We moved SyntaxError as a separate struct so we can make custom Display implementation
also add inside test reexport for parse::Error so there wouldn't be conflicts after deleteting Error variants
This also made change inside some modules to use ast::Error instead of error::Error.
gerau
force-pushed
the
simc/refactor-errors-split
branch
from
ddf1800 to
d1bb37b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementing the first step of the error refactor issue: #204 (comment).
I tried to keep the changes minimal, so I did not refactor RichError completely. Also, keep in mind that we will most likely remove
error::Errorand replace RichError with something more like a Diagnostic.