Skip to content

[ENG-9820]: cleanup and delete dead ES2 code#11688

Open
ihorsokhanexoft wants to merge 18 commits into
CenterForOpenScience:feature/es2-consolidationfrom
ihorsokhanexoft:feature/ENG-9820
Open

[ENG-9820]: cleanup and delete dead ES2 code#11688
ihorsokhanexoft wants to merge 18 commits into
CenterForOpenScience:feature/es2-consolidationfrom
ihorsokhanexoft:feature/ENG-9820

Conversation

@ihorsokhanexoft
Copy link
Copy Markdown
Contributor

@ihorsokhanexoft ihorsokhanexoft commented Apr 8, 2026

Ticket

https://openscience.atlassian.net/browse/ENG-9820

Purpose

After removing v1/v2 search endpoints, there is a lot of unused code that can be removed

Changes

Remove legacy code

IT IS HIGHLY RECOMMENDED TO REVIEW THIS PULL REQUEST COMMIT BY COMMIT

@Vlad0n20
Copy link
Copy Markdown
Contributor

Vlad0n20 commented May 8, 2026

Clean, well-scoped deletion. One missed cleanup: CoreScopes.SEARCH = 'search_read' at oauth_scopes.py:136 is left as a dead definition after its only usages are removed — should be deleted alongside ADVANCED_SEARCH. Also worth confirming whether /explore/ and /activity/ need infrastructure-level redirects before this merges. Everything else looks good.

@ihorsokhanexoft
Copy link
Copy Markdown
Contributor Author

ihorsokhanexoft commented May 11, 2026

Clean, well-scoped deletion. One missed cleanup: CoreScopes.SEARCH = 'search_read' at oauth_scopes.py:136 is left as a dead definition after its only usages are removed — should be deleted alongside ADVANCED_SEARCH. Also worth confirming whether /explore/ and /activity/ need infrastructure-level redirects before this merges. Everything else looks good.

But CoreScopes.SEARCH is used in BaseSearchView that many views inherit from:
image

So why should we remove it?

Copy link
Copy Markdown
Contributor

@Vlad0n20 Vlad0n20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants