Skip to content

Fix search facets slide animation in safari#5637

Merged
tdonohue merged 1 commit into
DSpace:mainfrom
atmire:fix-safari-animations-10.0.0-next
May 12, 2026
Merged

Fix search facets slide animation in safari#5637
tdonohue merged 1 commit into
DSpace:mainfrom
atmire:fix-safari-animations-10.0.0-next

Conversation

@artlowel
Copy link
Copy Markdown
Member

@artlowel artlowel commented May 8, 2026

References

Description

This gives <ds-search-facet-filter-wrapper> display:block so angular can calculate its height in safari, to make the slide animation work.

Instructions for Reviewers

Verify that the facets on the search page slide open properly in safari now, and that they still work as before in other browsers

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

@artlowel artlowel self-assigned this May 8, 2026
@artlowel artlowel added the bug label May 8, 2026
@artlowel artlowel added component: Discovery related to discovery search or browse system high priority ux User Experience related works testathon Reported by a tester during Community Testathon port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release affects: main Issue impacts "main" (latest release). affects: 8.x Issue impacts 8.x releases affects: 7.x Issue impacts 7.x releases port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release affects: 9.x Issue impacts 9.x releases labels May 8, 2026
@artlowel artlowel moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release May 8, 2026
@artlowel artlowel removed the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label May 8, 2026
@artlowel
Copy link
Copy Markdown
Member Author

artlowel commented May 8, 2026

@tdonohue I noticed it didn't cherry-pick clean to 7.x, but it does to 8.x and 9.x, so I created #5638 already. The 8 and 9 backports should work automatically

@saschaszott
Copy link
Copy Markdown
Contributor

@artlowel , thanks for submitting a PR. I applied the PR's changes to our DSpace 8.2 instance. The UI bug is fixed now.

@artlowel , can you say something about the root cause, and could this issue also occur elsewhere in the DSpace UI?

@MW3000 MW3000 self-requested a review May 11, 2026 06:53
Copy link
Copy Markdown
Contributor

@MW3000 MW3000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested your fix with DSpace 9.x and 10.x on both Safari 26.4 and Firefox 150.
It works with both DSpace versions on both browsers ✅

@lgeggleston lgeggleston moved this from 🙋 Needs Reviewers Assigned to 👍 Reviewer Approved in DSpace 10.0 Release May 12, 2026
@lgeggleston lgeggleston added the 1 APPROVAL pull request only requires a single approval to merge label May 12, 2026
@tdonohue tdonohue added this to the 10.0 milestone May 12, 2026
@tdonohue
Copy link
Copy Markdown
Member

Merging immediately as this is a verified fix from several testers. Thanks @artlowel ! (And thanks @saschaszott and @MW3000 for your quick testing!)

@tdonohue tdonohue merged commit 3bc783f into DSpace:main May 12, 2026
16 checks passed
@github-project-automation github-project-automation Bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 10.0 Release May 12, 2026
@dspace-bot
Copy link
Copy Markdown
Contributor

Successfully created backport PR for dspace-8_x:

@dspace-bot
Copy link
Copy Markdown
Contributor

Successfully created backport PR for dspace-9_x:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge affects: main Issue impacts "main" (latest release). affects: 7.x Issue impacts 7.x releases affects: 8.x Issue impacts 8.x releases affects: 9.x Issue impacts 9.x releases bug component: Discovery related to discovery search or browse system high priority port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release testathon Reported by a tester during Community Testathon ux User Experience related works

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Filter facet values overlap other filters in results list and become unusable on Safari

6 participants