Skip to content

Update FIBContext and backend logic for detecting, handling and making GIFs of drift correction images#796

Open
tieneupin wants to merge 20 commits intomainfrom
fib-gif-update
Open

Update FIBContext and backend logic for detecting, handling and making GIFs of drift correction images#796
tieneupin wants to merge 20 commits intomainfrom
fib-gif-update

Conversation

@tieneupin
Copy link
Copy Markdown
Contributor

@tieneupin tieneupin commented Apr 30, 2026

This PR updates the logic on the client and backend server used to construct GIFs of the drift correction images.

  • Creates and stores the output GIF file path once per site on the client side instead of reconstructing it each time on the server side
  • Uses the site info metadata parsed from the 'ProjectData.dat' file to determine the output GIF file path
  • Removes timestamp extraction logic, as the AutoTEM's drift correction images are automatically generated with the timestamp in the file name in yyyy-mm-dd-hh-mm-ss convention, which allow them to be sorted as strings
  • Adds logic to skip sending GIF creation requests if the metadata is not yet parsed, sending it only after the corresponding metadata information has been collected
  • Simplifies the API endpoint URL path and the parameters that need to be passed to the backend

Diff due to tests is about +270/-110.

Comment thread src/murfey/server/api/workflow_fib.py Fixed
Comment thread src/murfey/server/api/workflow_fib.py Fixed
Comment thread src/murfey/server/api/workflow_fib.py Fixed
Comment thread src/murfey/server/api/workflow_fib.py Fixed
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.29%. Comparing base (42a34ba) to head (b27e198).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #796      +/-   ##
==========================================
+ Coverage   52.14%   52.29%   +0.15%     
==========================================
  Files          96       96              
  Lines       10239    10316      +77     
  Branches     1340     1357      +17     
==========================================
+ Hits         5339     5395      +56     
- Misses       4627     4642      +15     
- Partials      273      279       +6     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tieneupin tieneupin marked this pull request as ready for review May 5, 2026 10:21
@tieneupin tieneupin self-assigned this May 5, 2026
@tieneupin tieneupin added server Relates to the server component client Relates to the client component fib Part of the FIB pipeline extension labels May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client Relates to the client component fib Part of the FIB pipeline extension server Relates to the server component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants