Allow for CUDA driver minor version compatibility#226
Open
ocaisa wants to merge 5 commits intoEESSI:mainfrom
Open
Allow for CUDA driver minor version compatibility#226ocaisa wants to merge 5 commits intoEESSI:mainfrom
ocaisa wants to merge 5 commits intoEESSI:mainfrom
Conversation
Member
Author
|
Ok, I think we are ready for showtime here: |
ocaisa
commented
May 8, 2026
Comment on lines
-164
to
-165
| local eessi_version = os.getenv('EESSI_VERSION') or "" | ||
| local eessi_eprefix = os.getenv("EESSI_EPREFIX") or "" |
Member
Author
There was a problem hiding this comment.
The test below checks for nil
ocaisa
commented
May 8, 2026
| -- even if it fails to set EESSI_CUDA_DRIVER_VERSION | ||
| -- Essentially, we handle that case here by raising an error, which can be suppressed | ||
| if not cudaVersion or cudaVersion == "" then | ||
| -- Having EESSICUDAVERSION set means we have an NVIDIA accelerator |
Member
Author
There was a problem hiding this comment.
Using this for forward thinking for when we have to deal with something similar for AMD
ocaisa
commented
May 8, 2026
| warn = warn .. "https://docs.nvidia.com/deploy/cuda-compatibility/minor-version-compatibility.html .\\n" | ||
| if not suppress_warn or suppress_warn == 1 then | ||
| LmodWarning("\\nYour driver CUDA version is ", cudaVersion, " ", warn) | ||
| setenv(suppress_var, "1") |
Member
Author
There was a problem hiding this comment.
Because of the way this is set up, this warning will only get printed once per session (the variable never gets unset, even after a module purge).
Member
Author
There was a problem hiding this comment.
I tried to work around this but it is quite complicated. If I am in an unload mode and the variable is set to the module name I want it unset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It works, but is a little too chatty: