fix(@effect/cli): use Ansi.blackBright for Weak spans so --help is readable on dark terminals#6208
Open
Zelys-DFKH wants to merge 1 commit intoEffect-TS:mainfrom
Open
Conversation
…adable on dark terminals Weak spans were annotated with Ansi.black (ANSI code 30), which is invisible on dark/black terminal backgrounds. Ansi.blackBright (code 90, dark gray) is readable on both dark and light terminals.
🦋 Changeset detectedLatest commit: 977a4eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6200
@effect/climarks "Weak" spans in--helpoutput withAnsi.black, which produces ANSI code30(black foreground). On dark terminal backgrounds (the default in most modern terminals), the text becomes black-on-black and disappears.NO_COLOR=1does not help; the styling is applied in the annotation layer before the renderer sees it.The fix is in
toAnsiDocinpackages/cli/src/internal/helpDoc/span.ts:Ansi.blackBrightis ANSI code90(dark gray), readable on dark and light backgrounds.Ansi.dimwould be cleaner semantically for de-emphasized text, but it is not exported by@effect/printer-ansi, soblackBrightis the right call within the current API.I added a regression test that renders a
Weakspan throughHelpDoc.toAnsiDocand asserts ANSI code30is absent. All 162 existing CLI tests pass.Love the library. Glad to contribute!