Skip to content

fix: handle null activeElement in _spaceCatcher AND fix: guard _moveManual and _ariaChecked against dom-repeat race AND MORE #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paodb merged 6 commits into from
May 7, 2026
Merged

fix: handle null activeElement in _spaceCatcher AND fix: guard _moveManual and _ariaChecked against dom-repeat race AND MORE #51

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
14392da
fix: handle null activeElement in _spaceCatcher
javier-godoy May 5, 2026
6893f6d
fix: guard _moveManual and _ariaChecked against dom-repeat race
javier-godoy May 5, 2026
e10daf9
refactor: replace var with const in _spaceCatcher
javier-godoy May 7, 2026
c8c9edf
refactor: use Number.parseInt with radix in _spaceCatcher
javier-godoy May 7, 2026
87452c3
fix: avoid duplicate click handlers accumulating in _moveManual
javier-godoy May 7, 2026
c2c9602
fix: bound-check position in _ariaChecked
javier-godoy May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 22 additions & 13 deletions src/main/resources/META-INF/resources/frontend/paper-slider/l2t-paper-slider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,10 +372,12 @@
_ariaChecked: function () {
var dotElems = this.$.container.querySelectorAll('.slider__dot');
if (dotElems.length > 0) {
for (var i = 0; i < this.totalSlides; i++) {
for (var i = 0; i < dotElems.length; i++) {
dotElems[i].setAttribute("aria-checked", "false");
};

Check warning on line 377 in src/main/resources/META-INF/resources/frontend/paper-slider/l2t-paper-slider.js

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Expected a `for-of` loop instead of a `for` loop with this simple iteration. 


See more on https://sonarcloud.io/project/issues?id=FlowingCode_CarouselAddon&issues=AZ3-LI4BkzfUE8jh3PVs&open=AZ3-LI4BkzfUE8jh3PVs&pullRequest=51
dotElems[this.position].setAttribute("aria-checked", "true");
if (this.position < dotElems.length) {
dotElems[this.position].setAttribute("aria-checked", "true");
}
}
},

Expand Down Expand Up @@ -478,13 +480,17 @@
_moveManual: function () {
var this$ = this;
var dotElems = this.$.container.querySelectorAll('.slider__dot'), i;
for (i = 0; i < this.totalSlides; ++i) {
for (i = 0; i < dotElems.length; ++i) {
dotElems[i].setAttribute("aria-label", "Slide " + parseInt(dotElems[i].getAttribute('aria-posinset')) + " selector");
dotElems[i].addEventListener('click', function (e) {
this$.movePos(e.target.getAttribute('aria-posinset') - 1);
});
};
if (this.totalSlides) {
if (!this._dotClickListener) {
this._dotClickListener = function (e) {
const dot = e.target.closest('.slider__dot');
if (dot) this$.movePos(Number.parseInt(dot.getAttribute('aria-posinset'), 10) - 1);
};
Comment thread
paodb marked this conversation as resolved.
this.$.container.addEventListener('click', this._dotClickListener);
}
if (dotElems.length) {
this._dotStyles = window.getComputedStyle(dotElems[0]);
}
},
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Expand Down Expand Up @@ -540,14 +546,13 @@
*/
_spaceCatcher: function (e) {
e.preventDefault();
if (this.shadowRoot != null) {
var nextPos = this.shadowRoot.activeElement.getAttribute('aria-posinset');
const activeEl = this.shadowRoot && this.shadowRoot.activeElement;

Check warning on line 549 in src/main/resources/META-INF/resources/frontend/paper-slider/l2t-paper-slider.js

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 


See more on https://sonarcloud.io/project/issues?id=FlowingCode_CarouselAddon&issues=AZ3-LI4BkzfUE8jh3PVt&open=AZ3-LI4BkzfUE8jh3PVt&pullRequest=51
if (activeEl) {
const nextPos = activeEl.getAttribute('aria-posinset');
if (nextPos) this.movePos(Number.parseInt(nextPos, 10) - 1);
} else {
var nextPos = document.activeElement.getAttribute('aria-posinset');
this.movePos((this.position + 1) % this.totalSlides);
}
if (!nextPos)
return;
this.movePos(parseInt(nextPos) - 1);
},
Comment thread
coderabbitai[bot] marked this conversation as resolved.

/**
Expand Down Expand Up @@ -657,6 +662,10 @@
detached: function() {
this.autoProgress = false;
removeListener(this.$.container, 'track', e => this._swipeHandler(e));
if (this._dotClickListener) {
this.$.container.removeEventListener('click', this._dotClickListener);
this._dotClickListener = null;
}
},

_increment: function(n) {
Expand Down
Loading