fix: prevent horizontal orientation from collapsing to zero height

[ngonzalezpazFC]

Close #201

Summary by CodeRabbit

• Bug Fixes
  • Improved grid layout styling to fix container sizing and orientation, resulting in more consistent component display and better responsiveness.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b66da008-8a75-4df1-bea2-f8ab9777bf7f

📥 Commits

Reviewing files that changed from the base of the PR and between 8a4d250 and 53846b8.

📒 Files selected for processing (1)

• src/main/java/com/flowingcode/vaadin/addons/twincolgrid/TwinColGrid.java

---

Walkthrough

Updated inline layout styles in TwinColGrid to change flex-basis values from 1 1 0px to 1 1 auto and replace a min-width constraint with min-height for the vertical container; no API, control flow, or public declarations were changed.

Changes

TwinColGrid layout fixes

Layer / File(s)	Summary
Layout style adjustment src/main/java/com/flowingcode/vaadin/addons/twincolgrid/TwinColGrid.java	In horizontal container: flex-basis changed from 1 1 0px to 1 1 auto.
Vertical container constraint src/main/java/com/flowingcode/vaadin/addons/twincolgrid/TwinColGrid.java	In vertical container: replaced min-width with min-height and changed flex-basis from 1 1 0px to 1 1 auto.
Context / Integration src/main/java/.../TwinColGrid.java (same file)	No changes to control flow, method signatures, or public API; edits are confined to inline style strings.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

• mlopezFC
• paodb

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main fix: preventing horizontal orientation from collapsing to zero height, which directly addresses the core issue being resolved.
Linked Issues check	✅ Passed	The PR implements the exact fix proposed in issue #201: changing flex-basis from '1 1 0px' to '1 1 auto' in both containers and fixing min-width to min-height in createVerticalContainer.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to fixing the horizontal orientation collapse issue; no unrelated modifications or side effects are introduced.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix-orientation-switch

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

• Generate code and open pull requests
• Plan features and break down work
• Investigate incidents and troubleshoot customer tickets together
• Automate recurring tasks and respond to alerts with triggers
• Summarize progress and report instantly

Built for teams:

• Shared memory across your entire org—no repeating context
• Per-thread sandboxes to safely plan and execute work
• Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[javier-godoy]

on hl was intentionally introduced in 457ce76 (Aug 2020) alongside flex: 1 1 0px to fix #15 (fixed height support). Replacing it with min-width: 0px removes a load-bearing property.

Both containers always live inside TwinColGrid, which extends VerticalLayout (a flex column). In that context, min-width: 0 has no effect — min-width: auto on a block-level flex item in a column already resolves to zero. It has been a no-op in createVerticalContainer since it was introduced in ccbd69c (Sep 2021).

The actual root cause of the collapse is flex-basis: 0px in flex: 1 1 0px. When TwinColGrid has no defined height, the inner container starts at zero and has nothing to grow into.

A correct fix:

• Change flex: 1 1 0px → flex: 1 1 auto in both createHorizontalContainer and createVerticalContainer
• Keep min-height: 0px in both (it is correct for flex items in a column and still needed for fixed-height support)
• Fix createVerticalContainer's min-width: 0px → min-height: 0px while at it

With flex-basis: auto, the container starts from its natural content height, so there is no collapse when TwinColGrid has no defined height. min-height: 0 still allows shrinking below content size when a fixed height is set on TwinColGrid.

Could you test with this approach?

Generated with Claude

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[javier-godoy]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[paodb]

Tested and it's working as expected.