fix(devdeps): update dependency @forgerock/javascript-sdk#617
fix(devdeps): update dependency @forgerock/javascript-sdk#617renovate[bot] wants to merge 1 commit intomainfrom
Conversation
|
|
View your CI Pipeline Execution ↗ for commit 3e76e55
☁️ Nx Cloud last updated this comment at |
9e597b9 to
04ecabc
Compare
04ecabc to
eed85dd
Compare
eed85dd to
3e76e55
Compare
There was a problem hiding this comment.
Nx Cloud is proposing a fix for your failed CI:
We updated the E2E test to fix the signoff detection broken by the @forgerock/javascript-sdk upgrade from 4.7.0 to 4.9.0. In the new SDK version, FRUser.logout({ logoutRedirectUri }) calls window.location.assign() instead of a fetch, so Playwright's waitForResponse can no longer intercept the intermediate 302 — replacing it with page.waitForURL('http://localhost:5829/') correctly tracks the resulting browser navigation back to the app.
Tip
✅ We verified this fix by re-running @forgerock/davinci-suites:e2e-ci--src/basic.test.ts.
diff --git a/e2e/davinci-suites/src/basic.test.ts b/e2e/davinci-suites/src/basic.test.ts
index 1da585d..786c00d 100644
--- a/e2e/davinci-suites/src/basic.test.ts
+++ b/e2e/davinci-suites/src/basic.test.ts
@@ -40,11 +40,7 @@ test('Test happy paths on test page', async ({ page }) => {
return true;
}
});
- const signoff = page.waitForResponse((response) => {
- if (response.url().includes('/signoff') && response.status() === 302) {
- return true;
- }
- });
+ const signoff = page.waitForURL('http://localhost:5829/');
await logoutButton.click();
await revokeCall;
await signoff;
Or Apply changes locally with:
npx nx-cloud apply-locally 4eJv-uNco
Apply fix locally with your editor ↗ View interactive diff ↗
🎓 Learn more about Self-Healing CI on nx.dev
This PR contains the following updates:
4.9.0→4.9.14.7.0→4.9.0Release Notes
ForgeRock/forgerock-javascript-sdk (@forgerock/javascript-sdk)
v4.9.1Compare Source
Patch Changes
d14d301Thanks @ForgeRockEmma! - fix: move getAuthenticationCredential back inside try/catch so that WebAuthn cancellation errors (e.g. NotAllowedError) are written to the HiddenValueCallback before re-throwingConfiguration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.