feat: 添加实例列表右键编辑功能 (#6000)#6038
Open
NWMA-FYWF wants to merge 4 commits intoHMCL-dev:mainfrom
Open
Conversation
NWMA-FYWF
commented
May 2, 2026
NWMA-FYWF
commented
- 实例列表项支持右键编辑
- 编辑页面名称唯一性验证排除自身
- 路径变化后不再自动修改名称
- 实例列表项支持右键编辑 - 编辑页面名称唯一性验证排除自身 - 路径变化后不再自动修改名称
Author
|
Glavo
reviewed
May 6, 2026
Member
Glavo
left a comment
Glavo
left a comment
There was a problem hiding this comment.
本审查建议由 GPT-5 生成
已将具体审查建议标注在对应代码行。
- 编辑时使用 profile.getName() 而非 getProfileDisplayName()，避免保留名称被翻译后保存 - locationChangeListener 只在新建设置时注册，编辑时禁用，避免路径变化自动重命名实例
Author
相关问题已在 提交 9cf13c7 中解决 |
Glavo
reviewed
May 9, 2026
- 使用 WeakListenerHolder + FXUtils.onWeakChange() 替代直接注册监听器 - 避免 ProfileListItem 与 Profile 之间形成强引用循环导致无法被 GC 回收
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.