Add user details in auth status#65
Conversation
|
Claude finished @ramilamparo's task in 2m 52s —— View job Review Summary
Result: Approved with one minor DRY suggestion on the The change is clean — switching from |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| export interface MeUser { | ||
| id: number | ||
| email: string | ||
| name: string | ||
| avatar: string | null | ||
| role: string | ||
| } |
There was a problem hiding this comment.
Nit: MeUser duplicates all of User's fields, with avatar being the only addition. Consider extending instead:
export interface MeUser extends User {
avatar: string | null
}This avoids the maintenance burden of keeping both interfaces in sync if shared fields change.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a5814a3d1a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
* Add interactive login * Address PR comments * Rename fields * Fix mocks * Address feedbacks * Few improvements * Clean up a bit * Import type * Refactor code to use standard oauth implementation. * Check suspended flag * Fix race condition in mocked imports * Update agent skill * Update table of contents * Fix issues * Fixes * Tweaks * Improve command description * Add refresh token expiration * Nits * Address PR review feedback - Restrict openBrowser URL scheme to http/https, surface execFile stderr - Restore withDevAuth middleware in createApi - Include client_id on refresh (RFC 6749 §6) and validate OAuth responses with Zod - Distinguish OAuth protocol vs transport errors so transient failures preserve credentials - Warn when stale-credential clear fails - Strip trailing slash on tenantUrl in apikey resolvers - Narrow credential source into ApiKeyCredentialSource | OAuthCredentialSource - Warn on partial QAS_TOKEN/QAS_URL config per source - Drop redundant pre-exit SIGINT removeListener calls - Reword --run-url host mismatch error to show both hosts - Cover OAuth bearer upload path and host-mismatch case in tests * Address second-pass review - Validate verification_uri / verification_uri_complete as URLs - Extract credentialsFromTokenResponse to deduplicate token-to-credentials mapping - Disable withHttpRetry on pollDeviceToken so the polling loop owns retry timing; treat 429/502/503 as transient and keep polling, honoring Retry-After - Share parseRetryAfterMs and DEFAULT_HTTP_RETRY_OPTIONS between withHttpRetry and the poll path * Add user details in `auth status` (#65)
3 participants
Sample output: