fix: correct examples configuration and fix validation data never being checked#91
Merged
meilame-tayebjee merged 6 commits intomainfrom May 7, 2026
Merged
fix: correct examples configuration and fix validation data never being checked#91meilame-tayebjee merged 6 commits intomainfrom
meilame-tayebjee merged 6 commits intomainfrom
Conversation
…set raw_labels=False
…e unused variable
…dation set and fix X_val always being None
julber95
changed the title
meilame-tayebjee
approved these changes
May 7, 2026
Member
|
Thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix several bugs in the examples scripts and core training logic:
Set raw_labels=False in all TrainingConfig calls since labels are already integer-encoded
Set raw_categorical_inputs=False in train and predict calls since categorical features are already integer-encoded
Remove check_val_every_n_epoch=2 which caused ModelCheckpoint to never save (val_loss unavailable on skipped epochs), leading to a crash on load_from_checkpoint
Fix X_val always being None, causing validation data to be silently ignored during training