Add a connectTimeout option to the TSC builder and DeterministicClient#163
Open
coltfred wants to merge 3 commits into
Open
Add a connectTimeout option to the TSC builder and DeterministicClient#163coltfred wants to merge 3 commits into
coltfred wants to merge 3 commits into
Conversation
giarc3
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous single timeout forced callers to choose one value for both connect and read. That made it awkward to fail fast on unreachable TSP hosts while still allowing a longer window for slow responses. The new option lets callers tune these independently without changing defaults for existing users.
connectTimeoutfor TSP requests, separate from the existing read timeout.TenantSecurityClient.BuildergainsconnectTimeoutMs(int). When unset, the connect timeout continues to followtimeoutMs(int), preserving the prior single-timeout behavior.DeterministicTenantSecurityClientcan be constructed directly using an independentreadTimeoutandconnectTimeoutvalues.