feat: add decoding as a multi-threaded CLARA engine#1229
Open
baltzell wants to merge 45 commits into
Open
Conversation
Collaborator
Author
auto-merge was automatically disabled
May 11, 2026 22:46
Pull request was converted to draft
f3aa485 to
40630b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

In the past year, the decoder was sped up enough to be usable as the (single-threaded) CLARA I/O service
DecoderReader. With current reconstruction speeds, that scales linearly up to about 32 threads, where it becomes I/O-bound by (single-threaded) decoding.This PR adds the decoder as a (multi-threaded) CLARA engine
DecoderEngine, based on a pool ofCLASDecoderobjects in lieu of a thread-safe decoder. Unlike other engines in COATJAVA, this implements CLARA'sEngineclass directly rather than extendingReconstructionEngine.For CCDB, new "share" constructors for
CLASDecoderandDetectorEventDecoderare added to inherit a previous instance'sConstantsManagerobjects and database connections, rather than initializing new ones. The maximum number of decoders sharing the same manager is currently hard-coded to 16 and may warrant some tuning.Here's the rough performance for a 24-thread job on a farm25 node with
etc/services/rgd-clarode.yml. The 12 ms/event for the DECO engine suggests some thread contention, e.g., synchronizedConstantsManagercalls, since it's few-ms when run single-threaded.