Refactor slice selection toolbar with toggle groups#94
Open
patrickoleary wants to merge 1 commit intomasterfrom
Open
Refactor slice selection toolbar with toggle groups#94patrickoleary wants to merge 1 commit intomasterfrom
patrickoleary wants to merge 1 commit intomasterfrom
Conversation
- Each variable is now a UI group with a toggle button showing the track name - When toggled, reveals editable textfield and slider controls - Groups wrap to new rows with flex-wrap when space is limited - Value label shows bold (t_idx) when collapsed, italic value+units always - Simplified top_padding calculation (no multi-row pre-computation needed) - Use default density for components, darker group outline, larger slider
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous slice selection toolbar displayed all variable sliders simultaneously, consuming significant vertical space and requiring complex multi-row height calculations. This made the UI cluttered, especially with many slice dimensions.
Before: All sliders visible at once, multi-row layout with pre-computed heights (70px × rows), large vertical footprint.
Redesigned the slice selection toolbar so each variable is presented as a compact toggle group:
After: Each variable shows a labeled toggle button with a summary label. Clicking the button expands inline editing controls (textfield + slider) for that variable only. Groups wrap naturally via flexbox when horizontal space is limited.
Changes