Issue 1090: Update annotations on custom Tasks to enable strict plugin validation#244
Open
labkey-susanh wants to merge 4 commits intodevelopfrom
Open
Issue 1090: Update annotations on custom Tasks to enable strict plugin validation#244labkey-susanh wants to merge 4 commits intodevelopfrom
labkey-susanh wants to merge 4 commits intodevelopfrom
Conversation
…ePlugin into fb_pluginValidation
labkey-tchad
approved these changes
May 9, 2026
| import org.gradle.api.Action | ||
| import org.gradle.api.Task | ||
| import org.gradle.api.file.FileTree | ||
| import org.gradle.api.tasks.UntrackedTask |
Member
There was a problem hiding this comment.
unused import
Suggested change
| import org.gradle.api.tasks.UntrackedTask |
Comment on lines
183
to
+184
| // N.B. Using Authorization Bearer with an API token does not currently work | ||
| httpPost.setHeader("Authorization", "Basic " + Base64.getEncoder().encodeToString("${project.property('artifactory_user')}:${project.property('artifactory_password')}".getBytes())) | ||
| httpPost.setHeader("Authorization", "Basic " + Base64.getEncoder().encodeToString("${project.property(BuildUtils.ARTIFACTORY_USER_PROP)}:${project.property(BuildUtils.ARTIFACTORY_PASSWORD_PROP)}".getBytes())) |
Member
There was a problem hiding this comment.
JFrog claims to support bearer tokens now. https://docs.jfrog.com/administration/docs/access-tokens#authorization-headers
No need to change it now but something to consider for the future.
labkey-adam
reviewed
May 9, 2026
| import org.gradle.api.tasks.PathSensitive | ||
| import org.gradle.api.tasks.PathSensitivity | ||
| import org.gradle.api.tasks.TaskAction | ||
| import org.gradle.api.tasks.UntrackedTask |
Contributor
There was a problem hiding this comment.
Suggested change
| import org.gradle.api.tasks.UntrackedTask |
labkey-adam
approved these changes
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Issue 1090: Stricter plugin validation was added in 9.4.0. The validation changes are meant to help with using the build cache. We use this on TeamCity if not for local builds. Keeping plugins compatible with the now-default behavior will reduce potential headaches.
Related Pull Requests
Changes
BuildUtils.hasArtifactoryPropertiesmethod for brevity@PathSensitiveannotations for a number of input properties