Skip to content

Auto-refactor lint cleanup#1371

Closed
labkey-jeckels wants to merge 2 commits into
developfrom
fb_lintCleanup
Closed

Auto-refactor lint cleanup#1371
labkey-jeckels wants to merge 2 commits into
developfrom
fb_lintCleanup

Conversation

@labkey-jeckels
Copy link
Copy Markdown
Contributor

@labkey-jeckels labkey-jeckels commented May 11, 2026

Rationale

Warnings can cover up important code quality issues.

Changes

  • SequencedCollections: get(0) -> getFirst(), etc
  • Add missing @NotNull/@Nullable
  • Simplify test assertions
  • Map operation simplification
  • Remove redundant throws clause
  • Switch to parameterized log message
  • C-style array -> Java-style array declaration
  • Delete overridden methods identical to parent
  • Switch statement -> enhanced switch statement
  • Remove redundant imports

Related Pull Requests

Tasks 📍

  • Claude Code Review
  • Manual Testing
  • Test Automation

SequencedCollections: get(0) -> getFirst(), etc
Add missing @NotNull/@nullable
Simplify test assertions
Map operation simplification
Remove redundant throws clause
Switch to parameterized log message
C-style array -> Java-style array declaration
Delete overridden methods identical to parent
Switch statement -> enhanced switch statement
Remove redundant imports
@labkey-jeckels labkey-jeckels self-assigned this May 11, 2026
@labkey-jeckels labkey-jeckels requested a review from a team May 12, 2026 00:00
@labkey-jeckels labkey-jeckels deleted the fb_lintCleanup branch May 12, 2026 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant