Support any number of flags in UVLOOP_OPT_CFLAGS#630
Merged
fantix merged 2 commits intoMagicStack:masterfrom May 4, 2026
Merged
Support any number of flags in UVLOOP_OPT_CFLAGS#630fantix merged 2 commits intoMagicStack:masterfrom
fantix merged 2 commits intoMagicStack:masterfrom
Conversation
Use `shlex.split()` to split the flags in `UVLOOP_OPT_FLAGS`, permitting the user to pass any number of flags rather than exactly one. This can be used e.g. to pass `-O2 -flto`.
fantix
approved these changes
May 4, 2026
Ari4ka
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
shlex.split()to split the flags inUVLOOP_OPT_FLAGS, permitting the user to pass any number of flags rather than exactly one. This can be used e.g. to pass-O2 -flto.