cuda.core: fix invalid python_version target in pixi.toml#2029
Open
rparolin wants to merge 1 commit intoNVIDIA:mainfrom
Open
cuda.core: fix invalid python_version target in pixi.toml#2029rparolin wants to merge 1 commit intoNVIDIA:mainfrom
rparolin wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Pixi's [package.target.<X>] only accepts platform identifiers; the
'python_version < "3.11"' selector caused every pixi invocation against
cuda_core/pixi.toml to fail at manifest-parse time
('python_version < "3.11"' is not a known platform).
Move backports.strenum into [package.run-dependencies] unconditionally
and let conda-forge's per-Python variants (real impl on <3.11, no-op
stub on >=3.12) handle version selection. Lockfile regenerated.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
mdboom
reviewed
May 5, 2026
Contributor
mdboom
left a comment
There was a problem hiding this comment.
Seems fine for pixi. Wouldn't want to ship this metadata in any package we ship, but fine for local use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cuda_core/pixi.tomlhad[package.target.'python_version < "3.11"'.run-dependencies], but pixi only accepts platform identifiers in[package.target.<X>]. Everypixi runagainst this manifest failed at parse time:backports.strenuminto the unconditional[package.run-dependencies]. Conda-forge ships per-Python variants (real impl gated topython <3.11, plus a 1.3.1 stub gated topython >=3.12), so the solver picks the right build perworkspace.build-variantsPython (3.10–3.14).backports.strenum-1.3.1now appears in the relevant environments.Why this slipped in
No CI workflow currently runs
pixi, so the broken stanza was never validated. Worth a follow-up to add apixi task listsmoke check, but out of scope here.Test plan
pixi task list --manifest-path cuda_core/pixi.toml— manifest parsespixi run --manifest-path cuda_core -e default test—3039 passed, 178 skipped, 2 xfailedpixi run testfrom repo root —3026 passed, 187 skipped, 2 xfailed🤖 Generated with Claude Code