Skip to content

feat: update cluster setup scripts for ONTAP 9 unified compatibility#31

Open
mahatvagarg wants to merge 3 commits into
mainfrom
feature/cluster-setup-scripts-unified-compatibility
Open

feat: update cluster setup scripts for ONTAP 9 unified compatibility#31
mahatvagarg wants to merge 3 commits into
mainfrom
feature/cluster-setup-scripts-unified-compatibility

Conversation

@mahatvagarg
Copy link
Copy Markdown
Collaborator

@mahatvagarg mahatvagarg commented May 13, 2026

Summary

Update cluster setup scripts for ONTAP 9 unified compatibility. Simplifies node discovery by removing version-specific field-set fallback logic and using a single unified field set that works across all ONTAP 9.x releases.

Changes

  • Python (cluster_setup_basic.py): Replaced 3-tier _NODE_FIELDS_SETS fallback with a single _NODE_FIELDS tuple; removed shebang and orchestrio reference.
  • Ansible (cluster_setup.yml): Removed disaggregated,san_optimized from node_query_fields; updated play name.

Checklist

General

  • No secrets, credentials, or API tokens in code or config

If touching python/

  • Scripts compile (python -m py_compile python/*.py)
  • Lint passes (ruff check python/)

If touching ansible/

  • Syntax check passes (ansible-playbook --syntax-check)
  • ansible-lint passes

Test Report

Environment: N/A — cannot run end-to-end
Platform version: Target: ONTAP 9.8+
Style touched: python, ansible

Static verification

  • python3 -m py_compile python/cluster_setup_basic.pyOK
  • YAML parse of ansible/cluster_setup.ymlOK
  • Changes are field-list reduction only (removed disaggregated,san_optimized); no new API calls, no logic changes.

Cannot run on a cluster?

This script performs initial cluster creation from unclustered nodes — it requires
two fresh ONTAP Simulator VMs in pre-cluster state. The change is a pure simplification:

  1. Python: replaced the 3-tier field-set fallback (_NODE_FIELDS_SETS) with a single
    _NODE_FIELDS tuple using the base ONTAP 9 fields. No behavioral change for ONTAP 9.8+.
  2. Ansible: removed disaggregated,san_optimized from node_query_fields to match.

Both files compile/parse cleanly. The removed fields (disaggregated, san_optimized)
were only available on ONTAP 9.18+/9.19+ — removing them makes the scripts work uniformly
across all ONTAP 9.x versions without the fallback retry loop.

Please apply the needs-test-run label so a maintainer with an unclustered simulator
environment can validate before merge.

Related issues

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 13, 2026

Test Report looks present - thanks. Reviewers will verify the captured output and idempotency evidence.

hvinn
hvinn previously approved these changes May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants