version-control-platform: add test to show wrong total on org#6
Open
sebastienbeau wants to merge 1 commit into
Open
version-control-platform: add test to show wrong total on org#6sebastienbeau wants to merge 1 commit into
sebastienbeau wants to merge 1 commit into
Conversation
Member
|
@sebastienbeau this is expected. We akready comented that we don't know the real organization of a user, so the only solution was to handle like received comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @etobella
The total on the partner company are not correct. Right now if a user from ORG 2 add a comment on a PR open by the ORG 1 the statistic will be counted for the ORG 1.
For now I just have added a test to show you the issue.
To fix it I propose:
adding a o2m on the res.partner to be able to store the historical company of a res.partner (with a table res.partner.history with start_date, end_date, company_id)
adding a computing field on the vcp.review / vcp.comment to compute the related company
For simple case the company of the partner is simply the parent_id of the partner that have done the contribution, in some advanced case (like Yannick Payot who was working at Camptocamp and then as Ascone) we can use the historical company mapping to be able to set the right company on the contribution.
What do you think ? If it's ok I will do it