Upgrade Java to 21#3
Open
onsabdulkalam wants to merge 6 commits into
Open
Conversation
onsabdulkalam
added
patch
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports
|
ryangrundy7
reviewed
May 12, 2026
ryangrundy7
reviewed
May 12, 2026
ryangrundy7
reviewed
May 13, 2026
ryangrundy7
reviewed
May 13, 2026
Contributor
ryangrundy7
left a comment
ryangrundy7
left a comment
There was a problem hiding this comment.
If you're changing the formatter, you'll need to update the make check command in the Makefile as it was using the old formatter. Just needs to be the spotless:check command it looks like
ryangrundy7
approved these changes
May 15, 2026
ryangrundy7
reviewed
May 15, 2026
Contributor
ryangrundy7
left a comment
ryangrundy7
left a comment
There was a problem hiding this comment.
I've approved it but you need to update the make format-check command to work with spotless
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Has the POM been updated?
Yes
The pom.xml file
project.versionmust be bumped appropriately on any code changes.done
Motivation and Context
Upgrade Java 17 to. 21
What has changed
pom.xml
Only version change
no
no test - ensure the build. is success. without any errors
How to test?
service up in running without any errors
Links
https://officefornationalstatistics.atlassian.net/browse/CN-12
Screenshots (if appropriate):