refactor!: migrate to python3#39
Conversation
| if type(value) == types.InstanceType: | ||
| value = JsonRpc.object_to_json_params(value) |
There was a problem hiding this comment.
types.InstanceType is removed in python3 but I am not confident this modification is OK
There was a problem hiding this comment.
Just coming back to MoleQueue - it looks okay, but I'll take a look as I work in on the modernization effort
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Eisuke Kawashima <e-kwsm@users.noreply.github.com>
No description provided.