Skip to content

refactor!: migrate to python3#39

Draft
e-kwsm wants to merge 1 commit intoOpenChemistry:masterfrom
e-kwsm:2to3
Draft

refactor!: migrate to python3#39
e-kwsm wants to merge 1 commit intoOpenChemistry:masterfrom
e-kwsm:2to3

Conversation

@e-kwsm
Copy link
Copy Markdown
Contributor

@e-kwsm e-kwsm commented May 21, 2025

No description provided.

Comment thread python/molequeue/utils.py
Comment on lines -52 to -53
if type(value) == types.InstanceType:
value = JsonRpc.object_to_json_params(value)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

types.InstanceType is removed in python3 but I am not confident this modification is OK

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just coming back to MoleQueue - it looks okay, but I'll take a look as I work in on the modernization effort

@e-kwsm e-kwsm marked this pull request as draft May 21, 2025 10:15
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 8, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8000015e-a4ca-4e9a-9eb6-eb79106766ec

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: Eisuke Kawashima <e-kwsm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants