Add documentation for Settings and Secrets API examples#493
Add documentation for Settings and Secrets API examples#493
Conversation
Documents: - examples/02_remote_agent_server/12_settings_and_secrets_api.py - examples/02_remote_agent_server/13_workspace_get_llm.py Covers: - Settings API for LLM configuration - Secrets API for encrypted secret storage - LookupSecret references for lazy resolution - workspace.get_llm(), get_secrets(), get_mcp_config() methods - Session API key authentication Co-authored-by: openhands <openhands@all-hands.dev>
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
xingyaoww
left a comment
There was a problem hiding this comment.
We should add this to docs.json - @OpenHands please update this in the custom code review guideline so we can prevent this in th efuture
all-hands-bot
left a comment
There was a problem hiding this comment.
Taste Rating: 🟡 Acceptable - Well-written documentation with one navigation issue
[CRITICAL ISSUE]
- Navigation Configuration: The new page
sdk/guides/agent-server/settings-api.mdxis missing fromdocs.json. It must be added to the "Remote Agent Server" group navigation (currently lists overview, local-server, docker-sandbox, apptainer-sandbox, api-sandbox, cloud-workspace, custom-tools). Without this entry, users won't find the page in the sidebar.
[POSITIVE NOTES]
- Documentation follows SDK guidelines correctly
- Good use of auto-sync code block placeholders
- Comprehensive security guidance
- Clear structure with appropriate examples
- Proper Mintlify component usage
[RISK ASSESSMENT]
Documentation-only change. No code modifications, no breaking changes. Content quality is high.
VERDICT:
❌ Needs rework - Add the page to docs.json navigation before merging.
KEY INSIGHT:
Excellent documentation of Settings and Secrets API with proper security emphasis, but missing navigation entry prevents discoverability.
Co-authored-by: openhands <openhands@all-hands.dev>
all-hands-bot
left a comment
There was a problem hiding this comment.
Taste Rating: 🟢 Good taste - Well-structured documentation following repository conventions
[RISK ASSESSMENT]
- [Overall PR]
⚠️ Risk Assessment: 🟢 LOW
Documentation-only changes adding Settings and Secrets API guide. Navigation properly configured, code block syntax correct for auto-sync, security considerations appropriately covered.
VERDICT:
✅ Worth merging: Clean documentation with proper structure and conventions
KEY INSIGHT:
The placeholder code blocks (<code will be auto-synced>) are expected behavior - the sync workflow will automatically populate them from the referenced example files in the agent-sdk repository.
Run sync_code_blocks.py to populate code blocks for: - examples/02_remote_agent_server/12_settings_and_secrets_api.py - examples/02_remote_agent_server/13_workspace_get_llm.py Co-authored-by: openhands <openhands@all-hands.dev>
Summary
Adds documentation for the Settings and Secrets API examples in the software-agent-sdk.
Examples Documented
examples/02_remote_agent_server/12_settings_and_secrets_api.py- Settings and Secrets API workflowexamples/02_remote_agent_server/13_workspace_get_llm.py- Workspace settings retrieval methodsDocumentation Covers
Settings API
/api/settingsOH_SECRET_KEYSecrets API
LookupSecretreferences for lazy resolutionWorkspace Settings Methods
workspace.get_llm()- Retrieve configured LLMworkspace.get_secrets()- Get LookupSecret referencesworkspace.get_mcp_config()- Get MCP configurationSecurity
Related SDK PR
Note: The branch name matches the SDK PR branch (
remote-workspace-settings-methods) so the SDK CI can find these docs.This PR was created by an AI agent (OpenHands) on behalf of the user.
@malhotra5 can click here to continue refining the PR