Minor improvement in v1 to v2 converter#479
Open
m-philipps wants to merge 6 commits intomainfrom
Open
Conversation
m-philipps
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #479 +/- ##
=======================================
Coverage 75.43% 75.43%
=======================================
Files 62 62
Lines 6899 6901 +2
Branches 1228 1229 +1
=======================================
+ Hits 5204 5206 +2
Misses 1223 1223
Partials 472 472 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dilpath
approved these changes
May 8, 2026
| ) | ||
| # some columns were dropped in PEtab v2 | ||
| if v1.C.INITIALIZATION_PRIOR_TYPE in df and ( | ||
| df[v1.C.INITIALIZATION_PRIOR_TYPE].notna().any() |
Member
There was a problem hiding this comment.
Fine for me to drop the notna check and warn regardless.
Comment on lines
+534
to
+538
| if not (df[v1.C.PARAMETER_SCALE] == v1.C.LIN).all(): | ||
| warnings.warn( | ||
| "Parameter scales are not supported in PEtab v2.", | ||
| stacklevel=9, | ||
| ) |
Member
There was a problem hiding this comment.
Same here, fine for me to warn if the column is present at all
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PARAMETER_SCALE,INITIALIZATION_PRIOR_TYPE,INITIALIZATION_PRIOR_PARAMETERSget_experiment_df