[ROCM-24669] pkg: drop hsa-rocr dep, warn at install time instead#300
Merged
Conversation
The relocatable DEB/RPM hard-depended on hsa-rocr, but ROCm 7.13 no
longer ships a package by that name -- install fails on TheRock 7.13
with "amdrocm7-transferbench depends on hsa-rocr; however: Package
hsa-rocr is not configured yet" (ROCM-24669).
The dep also never made sense for the relocatable artifact: it is
built from the TheRock SDK and meant to install on systems where ROCm
came from a tarball and is not tracked by apt/dpkg at all. Any apt
dep on a ROCm component breaks that audience.
Drop hsa-rocr from CPACK_DEBIAN_PACKAGE_DEPENDS,
CPACK_RPM_PACKAGE_REQUIRES, and the legacy
rocm_package_add_dependencies call. Wire a shared scriptlet
(packaging/postinst-check-hsa.sh) as the DEB postinst and the RPM
%post that probes ldconfig + the standard /opt/rocm{,-*,/extras-*,
/core-*}/lib prefixes for libhsa-runtime64.so.1 and prints a stderr
warning when none of them have it. Always exits 0 so install never
fails on its account -- the warning surfaces the missing runtime at
install time instead of as a dynamic-linker error on first run.
numactl / libnuma1 stay in the dep list since those are real OS
packages that exist independent of any ROCm install.
AtlantaPepsi
approved these changes
May 14, 2026
gilbertlee-amd
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ROCM-24669 —
amdrocm7-transferbenchDEB/RPM declares a hard dependency onhsa-rocr, which ROCm 7.13 no longer ships. Install fails on TheRock 7.13 withPackage hsa-rocr is not configured yet.Summary
hsa-rocrdep fromCPACK_DEBIAN_PACKAGE_DEPENDS,CPACK_RPM_PACKAGE_REQUIRES, and the legacyrocm_package_add_dependenciescall. The dep was wrong for the relocatable artifact in general — it ships against the TheRock SDK and is meant to install on systems where ROCm came from a tarball and is not tracked by apt/dpkg at all.packaging/postinst-check-hsa.shand wire it as both the DEB postinst (viaCPACK_DEBIAN_PACKAGE_CONTROL_EXTRA) and the RPM%post(viaCPACK_RPM_POST_INSTALL_SCRIPT_FILE). It probesldconfigand the standard/opt/rocm{,-*,/extras-*,/core-*}/libprefixes forlibhsa-runtime64.so.1and prints a stderr warning when none have it. Always exits 0 — install never fails on its account; the warning surfaces a missing runtime at install time instead of as a confusing dynamic-linker error on first invocation.numactl/libnuma1stay in the dep list since those are real OS packages that exist independent of any ROCm install.Behavior matrix
/opt/rocm/*hsa-rocrnot in dpkg)hsa-rocrinstalledTest plan
dpkg-deb -I amdrocm7-transferbench_*.debshowsDepends: numactl, libnuma1(nohsa-rocr) and lists apostinstin the control archive.rpm -qp --requires amdrocm7-transferbench-*.rpmshows onlynumactl(nohsa-rocr);rpm -qp --scriptsshows the%postbody.dpkg -iconfigures cleanly andTransferBenchlaunches.