fix(browser-metro): declare acorn-jsx as a direct dependency#20
Open
Saurabhwashere wants to merge 1 commit intoRapidNative:mainfrom
Open
fix(browser-metro): declare acorn-jsx as a direct dependency#20Saurabhwashere wants to merge 1 commit intoRapidNative:mainfrom
Saurabhwashere wants to merge 1 commit intoRapidNative:mainfrom
Conversation
transform-error.ts imports `acorn-jsx` (added in 1.0.15 alongside the
acorn-based syntax error reporter) but the package was never listed in
browser-metro/package.json's dependencies. In a workspaced monorepo it
silently resolves via dev-time workspace hoisting; published consumers
hit MODULE_NOT_FOUND at first import of Bundler / IncrementalBundler.
Repro against the npm artifact:
npm init -y
npm i browser-metro@1.0.17
node -e 'require("browser-metro")'
# → Error: Cannot find module 'acorn-jsx'
Fix is a one-line dependency add; ^5.3.2 matches what the acorn@8
ecosystem converges on.
|
@Saurabhwashere is attempting to deploy a commit to the Shaper Studio Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
transform-error.ts imports
acorn-jsx(added in 1.0.15 alongside the acorn-based syntax error reporter) but the package was never listed in browser-metro/package.json's dependencies. In a workspaced monorepo it silently resolves via dev-time workspace hoisting; published consumers hit MODULE_NOT_FOUND at first import of Bundler / IncrementalBundler.Repro against the npm artifact:
Fix is a one-line dependency add; ^5.3.2 matches what the acorn@8 ecosystem converges on.