Skip to content

fix: preserve toolbar connection status padding#1026

Merged
datlechin merged 2 commits intoTableProApp:mainfrom
overtrue-forks:feat/fix-toolbar-connection-padding
May 6, 2026
Merged

fix: preserve toolbar connection status padding#1026
datlechin merged 2 commits intoTableProApp:mainfrom
overtrue-forks:feat/fix-toolbar-connection-padding

Conversation

@overtrue
Copy link
Copy Markdown
Contributor

@overtrue overtrue commented May 6, 2026

Summary

  • Keep one resolved toolbar tag value for the principal toolbar content.
  • Add the missing leading inset when the connection status has no tag badge.
  • Update CHANGELOG.md under [Unreleased].

before

Clipboard_Screenshot_1778054553

after

Clipboard_Screenshot_1778054524

Validation

  • swiftlint lint --strict using the Xcode SwiftLint artifact: 0 violations.
  • xcodebuild -project TablePro.xcodeproj -scheme TablePro -configuration Debug build -skipPackagePluginValidation CODE_SIGNING_ALLOWED=NO CODE_SIGN_IDENTITY= CODE_SIGN_STYLE=Manual DEVELOPMENT_TEAM= PROVISIONING_PROFILE_SPECIFIER=: build succeeded.
  • git diff --check -- CHANGELOG.md TablePro/Views/Toolbar/TableProToolbarView.swift.
  • Staged diff wording check for banned words and em dash.

Notes

  • No tests added. This is a SwiftUI spacing-only fix.
  • swiftformat CLI is not installed in this environment, so I could not run it directly.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@overtrue
Copy link
Copy Markdown
Contributor Author

overtrue commented May 6, 2026

I have read the CLA Document and I hereby sign the CLA.

@overtrue overtrue marked this pull request as ready for review May 6, 2026 08:00
Copilot AI review requested due to automatic review settings May 6, 2026 08:00
@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a minor toolbar layout regression by preserving the connection status left inset when no tag badge is shown, while also avoiding redundant tag lookups in the principal toolbar content. It also records the fix in the changelog.

Changes:

  • Resolve the toolbar tag once and reuse it for both the badge and connection status tag name.
  • Add a conditional leading padding to the principal toolbar HStack when no tag badge is present.
  • Update CHANGELOG.md under [Unreleased] with the toolbar inset fix.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
TablePro/Views/Toolbar/TableProToolbarView.swift Reuses a single resolved tag value and adds conditional leading inset when no tag badge is displayed.
CHANGELOG.md Documents the toolbar inset fix under the Unreleased “Fixed” section.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread TablePro/Views/Toolbar/TableProToolbarView.swift Outdated
Copy link
Copy Markdown
Member

@datlechin datlechin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@datlechin datlechin merged commit ff719a2 into TableProApp:main May 6, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants