fix: preserve toolbar connection status padding#1026
fix: preserve toolbar connection status padding#1026datlechin merged 2 commits intoTableProApp:mainfrom
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
There was a problem hiding this comment.
Pull request overview
This PR fixes a minor toolbar layout regression by preserving the connection status left inset when no tag badge is shown, while also avoiding redundant tag lookups in the principal toolbar content. It also records the fix in the changelog.
Changes:
- Resolve the toolbar tag once and reuse it for both the badge and connection status tag name.
- Add a conditional leading padding to the principal toolbar HStack when no tag badge is present.
- Update
CHANGELOG.mdunder[Unreleased]with the toolbar inset fix.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| TablePro/Views/Toolbar/TableProToolbarView.swift | Reuses a single resolved tag value and adds conditional leading inset when no tag badge is displayed. |
| CHANGELOG.md | Documents the toolbar inset fix under the Unreleased “Fixed” section. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
CHANGELOG.mdunder[Unreleased].before
after
Validation
swiftlint lint --strictusing the Xcode SwiftLint artifact: 0 violations.xcodebuild -project TablePro.xcodeproj -scheme TablePro -configuration Debug build -skipPackagePluginValidation CODE_SIGNING_ALLOWED=NO CODE_SIGN_IDENTITY= CODE_SIGN_STYLE=Manual DEVELOPMENT_TEAM= PROVISIONING_PROFILE_SPECIFIER=: build succeeded.git diff --check -- CHANGELOG.md TablePro/Views/Toolbar/TableProToolbarView.swift.Notes
swiftformatCLI is not installed in this environment, so I could not run it directly.