Skip to content

fix: throw accountUnavailable from CloudKitSyncEngine.currentAccountId for consistency #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
datlechin merged 1 commit into from
May 6, 2026
+6 −5
Merged

fix: throw accountUnavailable from CloudKitSyncEngine.currentAccountId for consistency #1036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion TablePro/Core/Sync/CloudKitSyncEngine.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ actor CloudKitSyncEngine {
}

func currentAccountId() async throws -> String? {
guard let container else { return nil }
guard let container else { throw SyncError.accountUnavailable }
return try await container.userRecordID().recordName
}

Expand Down
9 changes: 5 additions & 4 deletions TableProTests/Core/Sync/CloudKitSyncEngineTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,12 @@ struct CloudKitSyncEngineTests {
}
}

@Test("currentAccountId returns nil without iCloud entitlement")
func currentAccountIdReturnsNil() async throws {
@Test("currentAccountId throws accountUnavailable without iCloud entitlement")
func currentAccountIdThrows() async throws {
try skipIfEntitled()
let engine = CloudKitSyncEngine()
let accountId = try await engine.currentAccountId()
#expect(accountId == nil)
await #expect(throws: SyncError.accountUnavailable) {
_ = try await engine.currentAccountId()
}
}
}
Loading