fix: pyright errors in ts_core.py#1234
Closed
Computerdores wants to merge 1 commit into
Closed
Conversation
Computerdores
added
the
Type: Refactor
Collaborator
Author
|
made obsolete by #1354 |
github-project-automation
Bot
moved this from 🏓 Ready for Review
to ✅ Done
in TagStudio Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Progress towards #1061 and #1232 by fixing the errors in ts_core.py.
What was easily fixable I fixed, the rest of the errors I prevented by marking the methods with NotImplementedErrors, since there is currently no code path that calls them.
Tasks Completed