refactor(gamelogic): Break switch cases of GameLogic::logicMessageDispatcher into separate functions

[xezon]

This change breaks all switch cases of GameLogic::logicMessageDispatcher into separate functions for ease of readability and maintainability.

The logic is unchanged.

TODO

• Replicate in Generals

[greptile-apps]

Greptile Summary

This PR extracts all switch case bodies from GameLogic::logicMessageDispatcher into dedicated on* member functions, each receiving only the parameters they require (primarily GameMessage *msg and optionally AIGroupPtr &currentlySelectedGroup). A shared getMessagePlayer helper is added to centralise player lookup.

• GameLogicDispatch.cpp loses ~1 600 lines of inline case logic and gains an equivalent set of named on* functions, with break → return false/true conversions that are semantically equivalent because callers still break out of the switch.
• Both Generals and GeneralsMD GameLogic.h headers gain the full set of on* declarations, the ALLOW_SURRENDER guarded trio, and the moved #include "GameLogic/AI.h" (removed from the .cpp).

Confidence Score: 5/5

Pure mechanical extraction of switch-case bodies into named member functions; all control-flow paths, ownership guards, and conditional compilation blocks are faithfully reproduced.

Every previously identified concern has been resolved: getMessagePlayer(msg) is called inside each function that needs msgPlayer, the ALLOW_SURRENDER trio correctly takes AIGroupPtr &currentlySelectedGroup, both headers carry the matching guarded declarations, and the onLogicCrc slot-finding loop still uses break with the subsequent return false correctly substituting for the original switch-level break. No new logic changes were introduced.

No files require special attention.

Important Files Changed

Filename	Overview
Core/GameEngine/Source/GameLogic/System/GameLogicDispatch.cpp	~1600-line refactor extracting all switch-case bodies into named on* member functions; all player-ownership guards, msgPlayer lookups via getMessagePlayer, AIGroupPtr parameters, and ALLOW_SURRENDER guards are correctly reproduced.
Generals/Code/GameEngine/Include/GameLogic/GameLogic.h	Adds the full on* declaration block matching the implementations, including properly guarded ALLOW_SURRENDER and debug-only declarations; adds #include "GameLogic/AI.h" for AIGroupPtr.
GeneralsMD/Code/GameEngine/Include/GameLogic/GameLogic.h	Mirror of the Generals header change; declaration set and preprocessor guards are consistent with the implementations.

Sequence Diagram

sequenceDiagram
    participant Caller
    participant logicMessageDispatcher
    participant on_Handler as on*() handler
    participant AIGroup
    participant TheNetwork

    Caller->>logicMessageDispatcher: msg, userData
    logicMessageDispatcher->>logicMessageDispatcher: getMessagePlayer(msg)
    logicMessageDispatcher->>logicMessageDispatcher: switch(msgType)
    logicMessageDispatcher->>on_Handler: onXxx(msg [, currentlySelectedGroup])
    alt needs player
        on_Handler->>on_Handler: getMessagePlayer(msg)
    end
    alt needs AI group
        on_Handler->>AIGroup: groupXxx(...)
    end
    alt MSG_LOGIC_CRC
        on_Handler->>TheNetwork: getPlayerName / isPlayerConnected
        on_Handler-->>logicMessageDispatcher: false (disconnected) or true (CRC written)
    end
    on_Handler-->>logicMessageDispatcher: bool result (unused)
    logicMessageDispatcher->>logicMessageDispatcher: break (exits switch)
    logicMessageDispatcher-->>Caller: (cleanup continues)

Loading

_{Reviews (4): Last reviewed commit: "Fix compile error" | Re-trigger Greptile}

[xezon]

Generals fails to compile until replicated.

[Caball009]

Do we need the braces per case? It makes the function a lot longer.

[xezon]

Do we need the braces per case? It makes the function a lot longer.

Is not strictly necessary. Braces are only needed if a variable needs declaration in the top switch case scope. Do you want it removed?

[Caball009]

I don't have a strong opinion on it either way, but I lean toward removing them to make the function shorter.