fix(memory): Fix memory leak for RecorderClass::m_crcInfo

[Caball009]

• Related PR fix(memory): Fix various memory leaks (2) #2710

This PR fixes a memory leak for RecorderClass::m_crcInfo. I decided to fix this one by not allocating the CRCInfo object dynamically. This did require a larger change of moving the class to the header, though.

See commits for clean diffs.

TODO:

• Replicate in Generals.

[greptile-apps]

Greptile Summary

This PR fixes a memory leak in RecorderClass by changing m_crcInfo from a heap-allocated CRCInfo* to a value-type member CRCInfo. To support default initialization, a no-arg constructor was added to CRCInfo, and the class definition was moved from the .cpp file into the RecorderClass definition in the header.

• CRCInfo is now a nested protected class inside RecorderClass in Recorder.h, with a default constructor that zero-initialises all fields.
• All m_crcInfo->member() call sites are updated to m_crcInfo.member(), and the heap allocation in playbackFile() is replaced with a value assignment — correctly destroying any previous queued CRC state on each new playback.

Confidence Score: 5/5

Safe to merge. The conversion from heap pointer to value member is mechanically straightforward, and repeated-playback state is correctly cleared by the move-assignment in playbackFile().

The change is tightly scoped: a class definition is moved to the header, a default constructor is added, and all access sites are updated from pointer to value. The compiler-generated move-assignment on std::list correctly drains any queued CRCs on each new playback, and the default constructor initialises all fields to well-defined values. No logic paths were altered.

No files require special attention.

Important Files Changed

Filename	Overview
GeneralsMD/Code/GameEngine/Include/Common/Recorder.h	CRCInfo moved here as a nested protected class with a new default constructor; m_crcInfo changed from pointer to value member.
GeneralsMD/Code/GameEngine/Source/Common/Recorder.cpp	CRCInfo class definition and file-local implementation removed; moved to header/scoped definitions. All pointer dereferences updated to value access.

_{Reviews (3): Last reviewed commit: "Made 'CRCInfo' class part of 'RecorderCl..." | Re-trigger Greptile}

[xezon]

Looking good. Needs replicate to Generals.

[xezon]

Can remove the empty lines here for compactness.

[xezon]

While at it, perhaps compact the format of the massive comment a bit.

[xezon]

While at it, prefer format like:

RecorderClass::CRCInfo::CRCInfo()
	: m_sawCRCMismatch(FALSE)
	, m_skippedOne(FALSE)

[xezon]

While at it

class RecorderClass : public SubsystemInterface
{