Skip to content

Submit the form when clicking on the selected currency#8

Draft
Tdank wants to merge 3 commits into
VirusAlex:masterfrom
Tdank:submitOnSelectedCurrencyClick
Draft

Submit the form when clicking on the selected currency#8
Tdank wants to merge 3 commits into
VirusAlex:masterfrom
Tdank:submitOnSelectedCurrencyClick

Conversation

@Tdank
Copy link
Copy Markdown

@Tdank Tdank commented May 5, 2026

When normally using the app I dislike having to scroll down to click calculate whenever I need to do a new amount.

With this minor addition you can also click on the selected currency button to calculate the bundles.
only works if the currency is already selected

draft:
will also add this to the tour later

@VirusAlex
Copy link
Copy Markdown
Owner

VirusAlex commented May 8, 2026

Hey! Problem is real, but clicking the selected currency to submit feels non-obvious
Two things:
1 -Enter already submits the form. "input type="number"" inside a "form" with a submit button does it natively in all browsers. Maybe you just didn't know?
2 - If we want a visible button - I'd rather duplicate submit as a small icon button on the right side of .amount-input-container, symmetric to the currency indicator on the left (like the search icon pattern). More natural. The bottom Calculate button can stay, both spots visible, dup is fine here

@Tdank
Copy link
Copy Markdown
Author

Tdank commented May 14, 2026

Pressing enter only works if the number input is focused. Today I noticed that I fill in the amount first then switch the currency, which means enter doesn't submit it. So pressing the currency button again feels somewhat natural to me.
To make it a bit more obvious I have added another tour step which explains it. ( I used google translate for the Russian text so it might need changing ). Hopefully that step might be enough for people to know about it.

as for other options.
Instead of adding a seconds button, "the number of variants" and the calculate button could be moved above the bundle stock options. That way it would not be below the screen, but it would mean the options are after the submit button.
Or perhaps a better way might be to move them above the results section, don't have the time now but perhaps ill see how it looks in the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants