You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey! Problem is real, but clicking the selected currency to submit feels non-obvious
Two things:
1 -Enter already submits the form. "input type="number"" inside a "form" with a submit button does it natively in all browsers. Maybe you just didn't know?
2 - If we want a visible button - I'd rather duplicate submit as a small icon button on the right side of .amount-input-container, symmetric to the currency indicator on the left (like the search icon pattern). More natural. The bottom Calculate button can stay, both spots visible, dup is fine here
Pressing enter only works if the number input is focused. Today I noticed that I fill in the amount first then switch the currency, which means enter doesn't submit it. So pressing the currency button again feels somewhat natural to me.
To make it a bit more obvious I have added another tour step which explains it. ( I used google translate for the Russian text so it might need changing ). Hopefully that step might be enough for people to know about it.
as for other options.
Instead of adding a seconds button, "the number of variants" and the calculate button could be moved above the bundle stock options. That way it would not be below the screen, but it would mean the options are after the submit button.
Or perhaps a better way might be to move them above the results section, don't have the time now but perhaps ill see how it looks in the weekend.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When normally using the app I dislike having to scroll down to click calculate whenever I need to do a new amount.
With this minor addition you can also click on the selected currency button to calculate the bundles.
only works if the currency is already selected
draft:
will also add this to the tour later