fix(embed): mark all tokens for output to suppress llama.cpp 'overriding' warning (#2208)#2209
Open
Anai-Guo wants to merge 1 commit intoabetlen:mainfrom
Open
fix(embed): mark all tokens for output to suppress llama.cpp 'overriding' warning (#2208)#2209Anai-Guo wants to merge 1 commit intoabetlen:mainfrom
Anai-Guo wants to merge 1 commit intoabetlen:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2208.
When
Llama.embed()is called with a model whose pooling type is notNONE, every input token'slogitsflag is set toFalseexcept the last (inLlamaBatch.add_sequence). When llama.cpp later runs the embedding pass it requires every embedded token to have its output flag enabled, so it emits one info line per input:then forces all tokens on internally. The output is correct but the log is noisy — see also the matching ollama issue ollama/ollama#12381 referenced in the bug report.
Fix
Set
logits_all = Trueunconditionally insideembed()so the Python side marks every token, matching what llama.cpp does internally. No behavioural change forLLAMA_POOLING_TYPE_NONE(alreadyTrue); for the other pooling modes the override-warning loop is suppressed.Test plan
model.embed(texts)with a pooled embedding model (e.g.nomic-embed-text-v1.5) — confirm theoverridinglines are gone and returned vectors are unchanged.model.embed(text, normalize=True)single-string call — output identical.model.embed(texts)with aLLAMA_POOLING_TYPE_NONEmodel — per-token embeddings unchanged.🤖 Generated with Claude Code