Skip to content

fix: improve memory monitor error message#1019

Draft
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1778380600-memory-monitor-error-message
Draft

fix: improve memory monitor error message#1019
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1778380600-memory-monitor-error-message

Conversation

@devin-ai-integration
Copy link
Copy Markdown
Contributor

Summary

  • Make the source memory monitor user-facing AirbyteTracedException message deterministic by removing the runtime memory percentage.
  • Keep detailed memory usage, anonymous memory share, and threshold details in internal_message for debugging.
  • Add a changelog entry for the CDK error message improvement.

Resolves https://github.com/airbytehq/airbyte-internal-issues/issues/16386
Related to https://github.com/airbytehq/oncall/issues/12486

Review & Testing Checklist for Human

  • Confirm the new user-facing message is clear enough for source container memory exhaustion and avoids remediation for system_error.
  • Confirm keeping FailureType.system_error is correct for CDK source-container memory exhaustion.
  • Confirm downstream connector users can still access the runtime percentage and cgroup details through internal_message.

Notes

  • Breaking change evaluation: this only changes the user-facing error string and changelog, and does not change schemas, state, spec, public APIs, or FailureType. I believe this is non-breaking.
  • Local test run: poetry run pytest unit_tests/utils/test_memory_monitor.py::test_raises_when_cgroup_critical_and_anon_share_of_usage_above_threshold -q.

Link to Devin session: https://app.devin.ai/sessions/fb2a62909bbf4de3b9149b01c76ea48c

@devin-ai-integration
Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@github-actions
Copy link
Copy Markdown

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

💡 Show Tips and Tricks

Testing This CDK Version

You can test this version of the CDK using the following:

# Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@devin/1778380600-memory-monitor-error-message#egg=airbyte-python-cdk[dev]' --help

# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch devin/1778380600-memory-monitor-error-message

PR Slash Commands

Airbyte Maintainers can execute the following slash commands on your PR:

  • /autofix - Fixes most formatting and linting issues
  • /poetry-lock - Updates poetry.lock file
  • /test - Runs connector tests with the updated CDK
  • /prerelease - Triggers a prerelease publish with default arguments
  • /poe build - Regenerate git-committed build artifacts, such as the pydantic models which are generated from the manifest JSON schema in YAML.
  • /poe <command> - Runs any poe command in the CDK environment
📚 Show Repo Guidance

Helpful Resources

📝 Edit this welcome message.

@github-actions
Copy link
Copy Markdown

PyTest Results (Fast)

4 043 tests  ±0   4 032 ✅ ±0   7m 57s ⏱️ +9s
    1 suites ±0      11 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 3ff188d. ± Comparison against base commit ccc185f.

@github-actions
Copy link
Copy Markdown

PyTest Results (Full)

4 046 tests  ±0   4 034 ✅ ±0   10m 57s ⏱️ -4s
    1 suites ±0      12 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 3ff188d. ± Comparison against base commit ccc185f.

@devin-ai-integration
Copy link
Copy Markdown
Contributor Author

↩️ Triggering /ai-review per Hands-Free AI Triage Project triage next step.

Reason: CDK PR is linked to a connector oncall issue, CI is passing or already has local/full pytest evidence, and no AI review marker is present.

Devin session

@devin-ai-integration
Copy link
Copy Markdown
Contributor Author

Correction: attempted to trigger the CDK /ai-review workflow programmatically, but this repository does not expose an ai-review-command.yml workflow and slash_command_dispatch.yml is not workflow-dispatchable. No AI review workflow was actually started.

This PR remains marked for human review/next-step decision.

Devin session

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants