Add tethering tests#36
Conversation
Signed-off-by: Eduardo Gonzalez <eduardo.gonzalez@amarulasolutions.com>
Signed-off-by: Eduardo Gonzalez <eduardo.gonzalez@amarulasolutions.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the tethering frequency setter to use a signed 32-bit integer variant and introduces new unit tests for enabling and disabling tethering. The review feedback highlights a type mismatch in the frequency setter, the incorrect use of assertion macros within asynchronous lambdas, potential race conditions in the test execution flow, and the need for better handling of environment-specific hardware dependencies in tests.
| } | ||
| }); | ||
| } | ||
| ASSERT_TRUE(called) << "setTethering callback was never called"; |
There was a problem hiding this comment.
This assertion will fail if no Wifi technology is found on the system, as called will remain false. This makes the test suite dependent on the host environment's hardware configuration. Consider checking for the existence of a Wifi technology and skipping the test (or marking it as successful/inconclusive) if none is found, rather than failing.
|
🧩 Build Artifacts ✅ The following build artifacts were produced: |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
1 participant
No description provided.