Support variable length sgpd boxes in fMPEG#3178
Support variable length sgpd boxes in fMPEG#3178dimitry-unified-streaming wants to merge 1 commit into
sgpd boxes in fMPEG#3178Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
For `sgpd` boxes with version >= 1, `the default_length` field is zero if the length of the following sample group entries is variable. Since the `FragmentedMp4Extractor` only supports one entry, skip the `description_length` field if applicable (e.g. when version >= 1 and `default_length` == 0), instead of throwing an error. For parsing the following CencSampleEncryptionInformationGroupEntry, this should make no difference. Issue: androidx#3177
24b3c04 to
fc6df15
Compare
|
Thank you for creating a PR for this feature! Would you please write some unit tests providing content with variable length sgpd boxes? |
|
Hey @dimitry-unified-streaming. We need more information to resolve this issue but there hasn't been an update in 14 weekdays. I'm marking the issue as stale and if there are no new updates in the next 7 days I will close it automatically. If you have more information that will help us get to the bottom of this, just add a comment! |
For
sgpdboxes with version >= 1,the default_lengthfield is zero if the length of the following sample group entries is variable.Since the
FragmentedMp4Extractoronly supports one entry, skip thedescription_lengthfield if applicable (e.g. when version >= 1 anddefault_length== 0), instead of throwing an error.For parsing the following CencSampleEncryptionInformationGroupEntry, this should make no difference.
Issue: #3177