Skip to content

Support variable length sgpd boxes in fMPEG#3178

Open
dimitry-unified-streaming wants to merge 1 commit into
androidx:releasefrom
dimitry-unified-streaming:fix-variable-length-sgpd-1
Open

Support variable length sgpd boxes in fMPEG#3178
dimitry-unified-streaming wants to merge 1 commit into
androidx:releasefrom
dimitry-unified-streaming:fix-variable-length-sgpd-1

Conversation

@dimitry-unified-streaming
Copy link
Copy Markdown

For sgpd boxes with version >= 1, the default_length field is zero if the length of the following sample group entries is variable.

Since the FragmentedMp4Extractor only supports one entry, skip the description_length field if applicable (e.g. when version >= 1 and default_length == 0), instead of throwing an error.

For parsing the following CencSampleEncryptionInformationGroupEntry, this should make no difference.

Issue: #3177

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Apr 16, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

For `sgpd` boxes with version >= 1, `the default_length` field is zero if the
length of the following sample group entries is variable.

Since the `FragmentedMp4Extractor` only supports one entry, skip the
`description_length` field if applicable (e.g. when version >= 1 and
`default_length` == 0), instead of throwing an error.

For parsing the following CencSampleEncryptionInformationGroupEntry, this should
make no difference.

Issue: androidx#3177
@microkatz
Copy link
Copy Markdown
Contributor

@dimitry-unified-streaming

Thank you for creating a PR for this feature! Would you please write some unit tests providing content with variable length sgpd boxes?

@google-oss-bot
Copy link
Copy Markdown
Collaborator

Hey @dimitry-unified-streaming. We need more information to resolve this issue but there hasn't been an update in 14 weekdays. I'm marking the issue as stale and if there are no new updates in the next 7 days I will close it automatically.

If you have more information that will help us get to the bottom of this, just add a comment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants