Several deprecations#33127
Open
alan-agius4 wants to merge 6 commits intoangular:mainfrom
Open
Conversation
555505e to
243e6dd
Compare
There was a problem hiding this comment.
Code Review
This pull request implements the deprecation of Angular's Webpack-based build system across several packages, including @angular-devkit/build-angular, @angular-devkit/build-webpack, and @ngtools/webpack. Changes include adding deprecation metadata to the release configuration, marking various interfaces and classes with @deprecated JSDoc tags, and introducing runtime warning logs in builders to guide users toward the newer esbuild and Vite-based @angular/build package. I have no feedback to provide.
DEPRECATED: CommonEngine APIs are deprecated in favor of AngularNodeAppEngine or AngularAppEngine.
DEPRECATED: Webpack builders in build-angular are deprecated. Use @angular/build builders instead.
…k-dev-server builders DEPRECATED: Webpack builders in build-webpack are deprecated. Use @angular/build builders instead.
DEPRECATED: @ngtools/webpack loader and plugin are deprecated. Use @angular/build instead.
Configures @angular-devkit/build-angular, @angular-devkit/build-webpack, and @ngtools/webpack as deprecated in the ng-dev release configuration.
243e6dd to
adb2b98
Compare
…and ssr/node packages Update golden files with deprecations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.