feat(@schematics/angular): set up fake timers in beforeEach instead of beforeAll#33130
Merged
clydin merged 1 commit intoangular:mainfrom May 5, 2026
Merged
Conversation
…f beforeAll When migrating `fakeAsync` to vitest fake timers, fake timers were setup in `beforeAll` to support `fakeAsync` usage in `beforeAll` / `afterAll` hooks. This was sacrificing timers isolation between tests. This change resets fake timers between tests. Any usage of fake timers APIs in `beforeAll` or `afterAll` hooks will fail.
angular-robot
Bot
added
detected: feature
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Jasmine-to-Vitest transformer to use "beforeEach" and "afterEach" hooks instead of "beforeAll" and "afterAll" when setting up and tearing down fake timers. This change ensures that fake timers are correctly initialized and reset for every individual test within a suite. I have no feedback to provide as there were no review comments to evaluate.
atscott
approved these changes
May 5, 2026
clydin
approved these changes
May 5, 2026
clydin
added
target: major
Member
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When migrating
fakeAsyncto Vitest fake timers, fake timers were setup inbeforeAllto supportfakeAsyncusage inbeforeAll/afterAllhooks.As brought up by @atscott, this was sacrificing timers isolation between tests.
This change resets fake timers between tests.
Any usage of fake timers APIs in
beforeAllorafterAllhooks will fail.PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information