Skip to content

refactor(aria/grid): consolidate widget focus logic and activation handling#33203

Merged
ok7sai merged 1 commit intoangular:mainfrom
ok7sai:refactor/widget-focus-and-activation
May 5, 2026
Merged

refactor(aria/grid): consolidate widget focus logic and activation handling#33203
ok7sai merged 1 commit intoangular:mainfrom
ok7sai:refactor/widget-focus-and-activation

Conversation

@ok7sai
Copy link
Copy Markdown
Member

@ok7sai ok7sai commented May 5, 2026

  • Removed the activated output from cell and use the one on widget instead.
  • Fixed the enter key cannot interact with simple widgets.

@ok7sai ok7sai force-pushed the refactor/widget-focus-and-activation branch from 4db6500 to 851cdeb Compare May 5, 2026 08:33
@ok7sai ok7sai marked this pull request as ready for review May 5, 2026 08:39
@pullapprove pullapprove Bot requested review from adolgachev and wagnermaciel May 5, 2026 08:39
@ok7sai ok7sai marked this pull request as draft May 5, 2026 08:42
@ok7sai ok7sai force-pushed the refactor/widget-focus-and-activation branch from 851cdeb to 4d74d42 Compare May 5, 2026 18:25
@ok7sai ok7sai added the dev-app preview When applied, previews of the dev-app are deployed to Firebase label May 5, 2026
@ok7sai ok7sai marked this pull request as ready for review May 5, 2026 18:28
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

Deployed dev-app for 4d74d42 to: https://ng-dev-previews-comp--pr-angular-components-33203-dev-bz64zb8y.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

Copy link
Copy Markdown
Contributor

@tjshiu tjshiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@ok7sai ok7sai added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels May 5, 2026
@ok7sai ok7sai merged commit f4e9a87 into angular:main May 5, 2026
34 checks passed
@ok7sai
Copy link
Copy Markdown
Member Author

ok7sai commented May 5, 2026

This PR was merged into the repository. The changes were merged into the following branches:

@ok7sai ok7sai deleted the refactor/widget-focus-and-activation branch May 5, 2026 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: aria/grid dev-app preview When applied, previews of the dev-app are deployed to Firebase target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants