feat(aria/combobox): migrate simple-combobox directly into primary entrypoints#33206
Open
tjshiu wants to merge 4 commits intoangular:mainfrom
Open
feat(aria/combobox): migrate simple-combobox directly into primary entrypoints#33206tjshiu wants to merge 4 commits intoangular:mainfrom
tjshiu wants to merge 4 commits intoangular:mainfrom
Conversation
tjshiu
added
target: major
|
Deployed dev-app for 2367284 to: https://ng-dev-previews-comp--pr-angular-components-33206-dev-fropu17d.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
ok7sai
approved these changes
May 5, 2026
crisbeto
reviewed
May 5, 2026
| @@ -1,4 +1,4 @@ | |||
| ## API Report File for "@angular/aria_combobox" | |||
| ## API Report File for "@angular/aria_deprecated_combobox" | |||
Member
There was a problem hiding this comment.
Given that Aria isn't stable yet, we can delete this code rather than going through a deprecation process.
Member
There was a problem hiding this comment.
We plan to migrate the internal usages later so we need a temporary place for the old combobox. It also provides a fallback if the migrations cause regression.
Member
There was a problem hiding this comment.
In that case maybe we should delete it externally and only leave it inside g3? The problem is that once we stabilize Aria, it'll take much longer to remove this code.
Contributor
Author
There was a problem hiding this comment.
okay - I removed the old combobox and replaced it with the new combobox. Thanks @crisbeto for the tips!
…points Relocate the public `src/aria/combobox` entrypoint to `src/aria/deprecated/combobox` and the private implementation patterns to `src/aria/private/deprecated/combobox`. This frees up the primary `combobox` namespace for the upcoming standalone combobox widget migration. - Add JSDoc `@deprecated` and `@breaking-change 22.0.0` markers to legacy classes and primitives. - Adjust relative imports outwards to accommodate the deeper directory nesting levels. - Re-wire build dependencies and entrypoint configurations across the framework package graph. - Bulk update consumer example module targets and prune unused dependencies.
…ementations Deletes the deprecated legacy combobox and autocomplete codebases, including their core entrypoints, integration layers within listbox and tree components, examples, dev-app pages, and associated API goldens.
…mbobox - Relocates public, private, and example directories to clean `combobox` entry points. - Renames internal layout symbols, selectors, and uppercase tokens (`SIMPLE_COMBOBOX_POPUP` -> `COMBOBOX_POPUP`). - Establishes full documentation extraction parity with the `json_api` Bazel rule target. - Standardizes the accompanying toolbar component showcase into the clean `aria-toolbar` path. - Re-routes dev-app navigation links and migrates public API golden records.
tjshiu
changed the title
…olbar examples Relocate the autocomplete examples to `src/components-examples/aria/autocomplete` and toolbar examples to `src/components-examples/aria/toolbar`. - Restore naming continuity with the historical codebase by stripping redundant prefixes from example filenames and component selectors. - Sync dev-app preview routing layout paths and strict Bazel target dependency links.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate the public
src/aria/simple-comboboxentrypoint tosrc/aria/comboboxand the private implementation patterns tosrc/aria/private/comboboxto complete the standalone widget migration.simple-prefix from all public/private component files, classes, selectors, and uppercase injection tokens.json_apiBazel rule extraction target.aria-toolbarentrypoint.