Skip to content

[C++][Parquet] Fix incorrect default in ArrowReaderProperties::set_pre_buffer doc#49911

Open
ArnavBalyan wants to merge 1 commit intoapache:mainfrom
ArnavBalyan:arnavb/fix-default
Open

[C++][Parquet] Fix incorrect default in ArrowReaderProperties::set_pre_buffer doc#49911
ArnavBalyan wants to merge 1 commit intoapache:mainfrom
ArnavBalyan:arnavb/fix-default

Conversation

@ArnavBalyan
Copy link
Copy Markdown
Member

Rationale for this change

  • The docs comment on ArrowReaderProperties::set_pre_buffer says default false, but the constructor initializes pre_buffer_(true). The published API page at arrow.apache.org/docs/cpp/api/formats.html contradicts the actual default.
  • Default was changed in a previous pr but comment/doc was not updated

What changes are included in this PR?

  • Update default

Are these changes tested?

  • Yes

Are there any user-facing changes?

  • Yes

@ArnavBalyan ArnavBalyan requested a review from wgtmac as a code owner May 3, 2026 08:10
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 3, 2026

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@ArnavBalyan
Copy link
Copy Markdown
Member Author

cc @pitrou thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant