CLVM enhancements and fixes by Pearl1594 · Pull Request #12617 · apache/cloudstack

Pearl1594 · 2026-02-09T19:47:40Z

Description

This PR enhances the existing CLVM implementation which was based on the deprecated CLVM technology which was based on corosync/pacemaker. With RHEL 7 having reached EOL, CLVM seems to be broken. CLVM supports RAW volumes on LVM , where as CLVM_NG support QCOW2 on LVM.

Further details: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Modernized+CLVM%3A+Enhancements+and+CLVM_NG+support

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov · 2026-02-09T20:01:42Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 3.68%. Comparing base (d3e1976) to head (df61d6f).
⚠️ Report is 15 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (d3e1976) and HEAD (df61d6f). Click for more details.

HEAD has 1 upload less than BASE

Flag BASE (d3e1976) HEAD (df61d6f)

unittests 1 0

Additional details and impacted files

@@              Coverage Diff              @@
##               main   #12617       +/-   ##
=============================================
- Coverage     17.90%    3.68%   -14.23%     
=============================================
  Files          5938      454     -5484     
  Lines        532864    38798   -494066     
  Branches      65192     7151    -58041     
=============================================
- Hits          95392     1428    -93964     
+ Misses       426793    37183   -389610     
+ Partials      10679      187    -10492

Flag	Coverage Δ
uitests	`3.67% <ø> (+<0.01%)`	⬆️
unittests	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…of running vm

Pearl1594 · 2026-02-11T19:43:29Z

@blueorangutan package

blueorangutan · 2026-02-11T19:44:04Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-02-11T20:28:42Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16801

weizhouapache · 2026-02-17T15:02:13Z

        UserVmVO vm = userVmDao.findById(vmId);
        String cantHandleLog = String.format("Default VM snapshot cannot handle VM snapshot for [%s]", vm);
+
+        if (isRunningVMVolumeOnCLVMStorage(vm, cantHandleLog)) {


@Pearl1594
what's the image format on CLVM ? RAW or QCOW2 ?

RAW @weizhouapache

codecov · 2026-02-17T15:24:41Z

Codecov Report

❌ Patch coverage is 43.40850% with 1305 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.35%. Comparing base (856d83a) to head (53e9b18).
⚠️ Report is 14 commits behind head on main.

Files with missing lines	Patch %	Lines
...oud/hypervisor/kvm/storage/ClvmStorageAdaptor.java	36.26%	436 Missing and 14 partials ⚠️
...ud/hypervisor/kvm/storage/KVMStorageProcessor.java	44.00%	135 Missing and 5 partials ⚠️
...stack/engine/orchestration/VolumeOrchestrator.java	23.46%	73 Missing and 2 partials ⚠️
...n/java/com/cloud/storage/VolumeApiServiceImpl.java	30.52%	62 Missing and 4 partials ⚠️
...ervisor/kvm/resource/LibvirtComputingResource.java	57.04%	53 Missing and 8 partials ⚠️
...resource/wrapper/LibvirtMigrateCommandWrapper.java	13.23%	52 Missing and 7 partials ⚠️
...wrapper/LibvirtClvmLockTransferCommandWrapper.java	37.63%	52 Missing and 6 partials ⚠️
...n/java/com/cloud/vm/VirtualMachineManagerImpl.java	15.62%	54 Missing ⚠️
...n/java/com/cloud/storage/clvm/ClvmPoolManager.java	73.52%	27 Missing and 18 partials ⚠️
...torage/motion/StorageSystemDataMotionStrategy.java	28.57%	35 Missing ⚠️
... and 28 more

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #12617      +/-   ##
============================================
+ Coverage     18.01%   18.35%   +0.34%     
- Complexity    16607    17223     +616     
============================================
  Files          6029     6048      +19     
  Lines        542154   549521    +7367     
  Branches      66451    68732    +2281     
============================================
+ Hits          97681   100885    +3204     
- Misses       433457   437445    +3988     
- Partials      11016    11191     +175

Flag	Coverage Δ
uitests	`3.51% <ø> (-0.01%)`	⬇️
unittests	`19.52% <43.40%> (+0.35%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Pearl1594 · 2026-02-18T16:33:12Z

@blueorangutan package

blueorangutan · 2026-02-18T16:40:04Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-02-18T17:32:01Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16875

Pearl1594 · 2026-02-18T20:23:11Z

@blueorangutan package

blueorangutan · 2026-02-18T20:24:04Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-02-18T21:16:21Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16877

…ached volumes

sureshanaparti · 2026-04-29T05:36:59Z

@blueorangutan package

blueorangutan · 2026-04-29T05:38:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-04-29T07:01:41Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17648

Pearl1594 · 2026-04-29T17:11:46Z

@blueorangutan package

blueorangutan · 2026-04-29T17:14:04Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-04-29T18:15:23Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17659

Pearl1594 · 2026-04-29T18:16:40Z

@blueorangutan test

blueorangutan · 2026-04-29T18:18:04Z

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>

sureshanaparti · 2026-04-30T06:32:55Z

+     * @param volume The CLVM volume
+     * @return Host ID that has the exclusive lock, or null if cannot be determined
+     */
+    private Long findVolumeLockHost(VolumeInfo volume) {


@Pearl1594 this method seems unused, please check.

Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>

sureshanaparti

clgtm

blueorangutan · 2026-04-30T08:47:50Z

[SF] Trillian test result (tid-15988)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 49309 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12617-t15988-kvm-ol8.zip
Smoke tests completed. 151 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

…as first check point and then fanning out

Pearl1594 · 2026-05-06T16:08:25Z

@blueorangutan package

blueorangutan · 2026-05-06T16:10:05Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

sonarqubecloud · 2026-05-06T16:44:23Z

Quality Gate failed

Failed conditions
1 Security Hotspot
33.4% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud

blueorangutan · 2026-05-06T16:59:09Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17742

Pearl1594 · 2026-05-06T17:18:10Z

@blueorangutan test

blueorangutan · 2026-05-06T17:20:04Z

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

boring-cyborg Bot added component:kvm component:storage labels Feb 9, 2026

CLVM enhancements and fixes

9e03f4b

Pearl1594 force-pushed the clvm-enhancements branch from 5fc1f12 to 9e03f4b Compare February 9, 2026 21:39

Pearl1594 added 2 commits February 10, 2026 19:48

add support for proper cleanup of snapshots and prevent vol snapshot …

96edadc

…of running vm

remove snap vol restriction for sunning vms

f9d8062

harikrishna-patnala added this to the 4.23.0 milestone Feb 17, 2026

weizhouapache reviewed Feb 17, 2026

View reviewed changes

Pearl1594 force-pushed the clvm-enhancements branch from a08e7a5 to df61d6f Compare February 17, 2026 15:04

refactor clvm code

43e9384

Pearl1594 force-pushed the clvm-enhancements branch from df61d6f to 43e9384 Compare February 17, 2026 15:16

boring-cyborg Bot added component:api component:compute component:orchestration labels Feb 17, 2026

add support for live migration

c9dd7ed

Pearl1594 force-pushed the clvm-enhancements branch from 3f900e8 to c9dd7ed Compare February 17, 2026 22:54

add support for migrating lvm lock

4984ee5

Pearl1594 added 2 commits February 19, 2026 15:42

clvm deletion called explicitly

190b201

made necessary changes to allow migration of lock and deletion of det…

8a7e48a

…ached volumes

Pearl Dsilva added 4 commits April 29, 2026 12:50

Create a CLVM storage adaptor

7caa9b5

update existing clvm get stats method

e3f1ccb

address comment

f29002b

fix precommit check failure

184024b

sureshanaparti reviewed Apr 30, 2026

View reviewed changes

Comment thread server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java Outdated

sureshanaparti reviewed Apr 30, 2026

View reviewed changes

Comment thread server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java Outdated

Apply suggestions from code review

360201b

Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>

sureshanaparti reviewed Apr 30, 2026

View reviewed changes

Comment thread server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java Outdated

sureshanaparti reviewed Apr 30, 2026

View reviewed changes

Comment thread server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java Outdated

sureshanaparti reviewed Apr 30, 2026

View reviewed changes

Apply suggestions from code review

f4502f1

Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>

sureshanaparti approved these changes Apr 30, 2026

View reviewed changes

Pearl1594 force-pushed the clvm-enhancements branch from 382b67d to 1143aeb Compare May 6, 2026 15:42

improve lock host retrieval logic and quicker retrival using db host …

53e9b18

…as first check point and then fanning out

Pearl1594 force-pushed the clvm-enhancements branch from 1143aeb to 53e9b18 Compare May 6, 2026 15:43

Conversation

Pearl1594 commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov Bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Pearl1594 commented Feb 11, 2026

Uh oh!

blueorangutan commented Feb 11, 2026

Uh oh!

blueorangutan commented Feb 11, 2026

Uh oh!

weizhouapache Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Pearl1594 Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Pearl1594 commented Feb 18, 2026

Uh oh!

blueorangutan commented Feb 18, 2026

Uh oh!

blueorangutan commented Feb 18, 2026

Uh oh!

Pearl1594 commented Feb 18, 2026

Uh oh!

blueorangutan commented Feb 18, 2026

Uh oh!

blueorangutan commented Feb 18, 2026

Uh oh!

sureshanaparti commented Apr 29, 2026

Uh oh!

blueorangutan commented Apr 29, 2026

Uh oh!

blueorangutan commented Apr 29, 2026

Uh oh!

Pearl1594 commented Apr 29, 2026

Uh oh!

blueorangutan commented Apr 29, 2026

Uh oh!

blueorangutan commented Apr 29, 2026

Uh oh!

Pearl1594 commented Apr 29, 2026

Uh oh!

blueorangutan commented Apr 29, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sureshanaparti Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Apr 30, 2026

Uh oh!

Pearl1594 commented May 6, 2026

Uh oh!

blueorangutan commented May 6, 2026

Uh oh!

sonarqubecloud Bot commented May 6, 2026

Quality Gate failed

Uh oh!

blueorangutan commented May 6, 2026

Pearl1594 commented Feb 9, 2026 •

edited

Loading

codecov Bot commented Feb 9, 2026 •

edited

Loading

codecov Bot commented Feb 17, 2026 •

edited

Loading