fix(http-client): enable got retry for transient server errors on POS…#877
Merged
programminx-askui merged 3 commits intoApr 10, 2026
Merged
Conversation
…T requests (#SOLENG-333) Remove `throwHttpErrors: false` from the POST method so that got's built-in retry mechanism (5 retries, exponential backoff) can trigger for transient server errors (500, 502, 503, 504). Previously, got silently returned error responses without retrying because it did not see them as errors. After retries are exhausted, HTTPError is caught and converted to our custom error hierarchy for consistent handling. This fixes intermittent CUDNN_STATUS_INTERNAL_ERROR (500) responses from the Azure GPU backend that cannot be fixed server-side. Refs: SOLENG-333 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…SOLENG-333) Got now handles all non-2xx responses via HTTPError, making the manual statusCode !== 200 check unnecessary. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…OLENG-333) Wrap non-HTTPError exceptions (network errors, timeouts, etc.) in UnkownHttpClientError for consistent error handling across the HttpClientError hierarchy. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mlikasam-askui
approved these changes
Apr 10, 2026
programminx-askui
deleted the
fix/SOLENG-333-enable-got-retry-for-server-errors
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…T requests (#SOLENG-333)
Remove
throwHttpErrors: falsefrom the POST method so that got's built-in retry mechanism (5 retries, exponential backoff) can trigger for transient server errors (500, 502, 503, 504). Previously, got silently returned error responses without retrying because it did not see them as errors. After retries are exhausted, HTTPError is caught and converted to our custom error hierarchy for consistent handling.This fixes intermittent CUDNN_STATUS_INTERNAL_ERROR (500) responses from the Azure GPU backend that cannot be fixed server-side.
Refs: SOLENG-333