fix(pypi): pass the correct versions to get_index_urls to write all facts that we need#3758
Open
aignas wants to merge 4 commits intobazel-contrib:mainfrom
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request ensures that all package versions from requirement files are recorded in the lock file, regardless of platform markers, by moving the distribution collection logic in parse_requirements.bzl. It also adds a regression test and updates the changelog for version 2.0.1. Feedback suggests optimizing the new collection logic to avoid redundant processing and to only run when an index query is necessary.
rickeylev
approved these changes
May 8, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the versions of packages that we are recording to a
MODULE.bazel.lockfile facts by passing all of the versions to the
get_indexfunction.Summary:
Fixes #3756