fix(toolchains): add releases.astral.sh mirror for python-build-standalone#3761
Merged
rickeylev merged 1 commit intobazel-contrib:mainfrom May 8, 2026
Merged
Conversation
…alone Currently, python-build-standalone runtimes are only downloaded from github.com. If github.com is down or experiencing 5xx errors, builds will fail because the runtimes cannot be fetched. To fix this, add releases.astral.sh as a secondary fallback mirror URL. If the requested base_url starts with the standard or legacy github.com release prefix, we append the equivalent releases.astral.sh URL to rendered_urls.
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements a mirroring mechanism for Python build standalone releases by adding releases.astral.sh as a secondary download source when GitHub or legacy GitHub URLs are used. The changes include defining new URL prefixes, updating get_release_info to handle multiple base URLs, and adding unit tests to verify the mirroring logic. Review feedback suggests refactoring the prefix definitions to eliminate string duplication and simplifying the logic for appending mirror URLs by iterating over the known prefixes.
aignas
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, python-build-standalone runtimes are only downloaded from
github.com. If github.com is down or experiencing 5xx errors, builds
will fail because the runtimes cannot be fetched.
To fix this, add releases.astral.sh as a secondary fallback mirror URL.
If the requested base_url starts with the standard or legacy github.com
release prefix, we append the equivalent releases.astral.sh URL to
rendered_urls.