Return lookup results as arrays#12
Merged
shuchenliu merged 3 commits intomainfrom May 8, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the NameResolution API /lookup and /bulk-lookup responses to return lookup results as arrays (to match the Solr CI response shape) and adjusts the integration contract tests accordingly.
Changes:
- Change
/lookupto return a JSON array of result objects instead of a CURIE-keyed dictionary. - Add a
finish_jsonhelper to safely return top-level JSON lists from Tornado handlers. - Update API contract tests to assert list-shaped lookup results (including
/bulk-lookupvalues).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/nameres/handlers/lookup.py |
Switches lookup result aggregation to a list and updates handler response writing. |
src/nameres/handlers/base.py |
Adds finish_json() to emit JSON for top-level list responses. |
test/test_api_contract.py |
Updates contract expectations from dict-shaped to list-shaped lookup results. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solving #10
The
/lookupand/bulk-lookupendpoints now match the response shape used by Solr CI.